map!, similar and eltype for DArray and SharedArrays #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge this in a day, if there are no concerns. |
|
LGTM |
amitmurthy
added a commit
that referenced
this pull request
Feb 25, 2014
map!, similar and eltype for DArray and SharedArrays
| similar{T}(d::DArray{T}, dims::Dims)= similar(d, T, dims) | ||
| similar{T}(d::DArray{T})= similar(d, T, size(d)) | ||
|
|
||
| eltype{T}(d::DArray{T}) = T |
There was a problem hiding this comment.
Shouldn't be necessary --- DArray will inherit the definition from AbstractArray.
There was a problem hiding this comment.
Yes. Removed in 8854bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context - https://groups.google.com/d/msg/julia-dev/MqJbvGiJ9dc/SqNL-esi3kcJ
Also closes #5893. It doesn't address the larger issue of a portable interface across Array, DArray and SharedArrays.