-
-
Couldn't load subscription status.
- Fork 5.7k
Precompile out of env deps in serial within precompilepkgs #59122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precompile out of env deps in serial within precompilepkgs #59122
Conversation
0513943 to
a52e387
Compare
|
One thing that needs figuring out here is that the previous So there are some tests that actually precompile packages that are being tripped up that monitor stderr. I'm not sure whether to fix tests here, or restore that hidden precompilation behavior.. I opted to keep it printing to stderr in noninteractive mode too and fix tests. I think its ok to print this stuff to stderr. |
608fbc7 to
c8d052f
Compare
This reverts commit 095d61f.
59f19fc to
2e11944
Compare
4586842 to
6e46271
Compare
Should this be labelled And should it be attached to the I worry that |
|
|
(cherry picked from commit 9808816)
(cherry picked from commit 9808816)
Fixes #59121
Brings serial precompilation jobs into the parallel precompilation job, so users don't have to hit the old error-looking serial log path.
These jobs will likely take longer because they may be precompiling their deps internally, so the
(serial)label has been added.Master
PR
Todo
(serial)means in the docs