Skip to content

Conversation

@IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jul 28, 2025

Fixes #59121

Brings serial precompilation jobs into the parallel precompilation job, so users don't have to hit the old error-looking serial log path.

These jobs will likely take longer because they may be precompiling their deps internally, so the (serial) label has been added.

Master

Screenshot 2025-07-28 at 5 10 32 PM

PR

Screenshot 2025-07-28 at 5 12 22 PM Screenshot 2025-07-28 at 5 12 45 PM

Todo

  • Explain what (serial) means in the docs

@IanButterworth
Copy link
Member Author

IanButterworth commented Jul 29, 2025

One thing that needs figuring out here is that the previous [Info : Precompiling logs were hidden @debugs on non-interactive mode. But Base.precompilepkgs always prints to stderr (unless there's nothing to be done).

So there are some tests that actually precompile packages that are being tripped up that monitor stderr.

I'm not sure whether to fix tests here, or restore that hidden precompilation behavior..


I opted to keep it printing to stderr in noninteractive mode too and fix tests. I think its ok to print this stuff to stderr.

@IanButterworth IanButterworth added the packages Package management and loading label Jul 30, 2025
@IanButterworth IanButterworth force-pushed the ib/precompile_serial branch 2 times, most recently from 59f19fc to 2e11944 Compare August 1, 2025 19:55
@IanButterworth IanButterworth merged commit 9808816 into JuliaLang:master Aug 2, 2025
7 checks passed
@topolarity
Copy link
Member

the (serial) label has been added.

Should this be labelled (non-parallel) or (single-process)?

And should it be attached to the Precompiling... prompt, instead of individual packages?

I worry that (serial) is only obvious if you've already been taught what "serial pre-compilation" means - One might walk away with the impression that this is compiling a customized version of the package (esp. since that's what, e.g., gray -O3 text in the same spot means)

@IanButterworth IanButterworth deleted the ib/precompile_serial branch September 15, 2025 14:50
@IanButterworth
Copy link
Member Author

(non-parallel) SGTM

KristofferC pushed a commit that referenced this pull request Oct 12, 2025
KristofferC pushed a commit that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Package management and loading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear error message when needing to precompile due to incompatible stacked environment

3 participants