-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fix and test stdlib JLL deps on Windows #58560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and test stdlib JLL deps on Windows #58560
Conversation
test/stdlib_dependencies.jl
Outdated
| is_system_lib = is_system_lib_macos | ||
| elseif Sys.iswindows() | ||
| # On Windows, we need `dumpbin` available | ||
| if Sys.which("dumpbin") === nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shipped with Visual Studio IIRC, so unlikely to be on the CI machines
I wonder if we have to use ObjectFile.jl instead? I'm not aware of any other open-source / freely-distributed utility to print this on Windows, but maybe @staticfloat knows of something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how easy it is for us to install ObjectFile during base tests, that's why I punted on this and just used CLI tools when available. I usually use readelf cross-compiled for Windows to do this kind of dumping, but of course that's not available on the tester images, only the builder images. We could download, for instance, this archive and use the readelf within it to dump the dependencies perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that readelf is also missing on some of the linux runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have llvm-tools, which include readobj/readelf that can parse the info llvm-readelf --coff-imports with that artifact, which means you can also get there from libLLVM's COFFObjectFile (though it doesn't look like you can get there from the C API)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe llvm-tools requires running a make install which hasn't been run on these runners? I'm trying ObjectFile.jl, which works on macOS
ab6f9ad to
786b116
Compare
786b116 to
101a4c6
Compare
stdlib/CompilerSupportLibraries_jll/src/CompilerSupportLibraries_jll.jl
Outdated
Show resolved
Hide resolved
1f992a1 to
d3bca9a
Compare
1d5d2b1 to
113c668
Compare
Co-authored-by: Mosè Giordano <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.