doc: Fix version reading in Makefile on Windows #58536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copied this expression from the toplevel Makefile, but here we need to read the version eargerly, because otherwise cygpath_w does not work. This had broken the windows build, but I did not notice due to the ongoing CI difficulties.
DilumAluthge
approved these changes
May 27, 2025
Might be useful to add this explanation as a comment in the Makefile? |
|
Build passed on Windows so merging to not block other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied this expression from the toplevel Makefile, but here we need to read the version eargerly, because otherwise cygpath_w does not work. This had broken the windows build, but I did not notice due to the ongoing CI difficulties.