gf.c: Add some comments to ml_matches (NFC)
#58304
Merged
+82
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
changed the title
ml_matchesml_matches (NFC)
vtjnash
reviewed
May 2, 2025
Mostly an exercise for me to go through this code in detail, but these seemed like useful breadcrumbs for the next reader.
vtjnash
force-pushed
the
ct/ml_matches-comments
branch
from
bba0f22 to
b1fcfdc
Compare
vtjnash
added
merge me
oscardssmith
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Sep 24, 2025
Adding notes as I go through this code in detail. Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit f2cc6b0)
24 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 24, 2025
Adding notes as I go through this code in detail. Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit f2cc6b0)
KristofferC
removed
the
backport 1.12
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
Adding notes as I go through this code in detail. Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding notes as I go through this code in detail.