Skip to content

fix #58013, error for too few arguments in invokelatest #58056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix #58013, error for too few arguments in invokelatest #58056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/builtins.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ JL_CALLABLE(jl_f__apply_iterate)
// this is like a regular call, but always runs in the newest world
JL_CALLABLE(jl_f_invokelatest)
{
JL_NARGSV(invokelatest, 1);
jl_task_t *ct = jl_current_task;
size_t last_age = ct->world_age;
if (!ct->ptls->in_pure_callback)
Expand All @@ -859,10 +860,10 @@ JL_CALLABLE(jl_f_invokelatest)
// If world > jl_atomic_load_acquire(&jl_world_counter), run in the latest world.
JL_CALLABLE(jl_f_invoke_in_world)
{
JL_NARGSV(_apply_in_world, 2);
JL_NARGSV(invoke_in_world, 2);
jl_task_t *ct = jl_current_task;
size_t last_age = ct->world_age;
JL_TYPECHK(_apply_in_world, ulong, args[0]);
JL_TYPECHK(invoke_in_world, ulong, args[0]);
size_t world = jl_unbox_ulong(args[0]);
if (!ct->ptls->in_pure_callback) {
ct->world_age = jl_atomic_load_acquire(&jl_world_counter);
Expand All @@ -877,7 +878,7 @@ JL_CALLABLE(jl_f_invoke_in_world)
JL_CALLABLE(jl_f__call_in_world_total)
{
JL_NARGSV(_call_in_world_total, 2);
JL_TYPECHK(_apply_in_world, ulong, args[0]);
JL_TYPECHK(_call_in_world_total, ulong, args[0]);
jl_task_t *ct = jl_current_task;
int last_in = ct->ptls->in_pure_callback;
jl_value_t *ret = NULL;
Expand Down
3 changes: 3 additions & 0 deletions test/worlds.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
using Base: get_world_counter, tls_world_age
@test typemax(UInt) > get_world_counter() == tls_world_age() > 0

# issue #58013
@test_throws ArgumentError invokelatest()

# test simple method replacement
begin
g265a() = f265a(0)
Expand Down