inference: simplify abstract_eval_globalref
#58026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
By moving the optional `assume_bindings_static` refinement logic into `abstract_eval_globalref_partition` and removing the redirect via `abstract_eval_globalref_partition`. Also adds test cases with `assume_bindings_static=true`.
aviatesk
force-pushed
the
avi/simplify-abstract_eval_globalref
branch
from
e06ad83 to
b2947aa
Compare
|
Change is fine by me. I don't know that I can say it is simpler, but if it helps for JET, I'm happy with the change. |
51 tasks
aviatesk
added a commit
that referenced
this pull request
Apr 9, 2025
By moving the optional `assume_bindings_static` refinement logic into `abstract_eval_partition_load` and removing the redirect via `abstract_eval_globalref_partition`. Also adds test cases with `assume_bindings_static=true`.
KristofferC
removed
the
backport 1.12
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
By moving the optional `assume_bindings_static` refinement logic into `abstract_eval_partition_load` and removing the redirect via `abstract_eval_globalref_partition`. Also adds test cases with `assume_bindings_static=true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the optional
assume_bindings_staticrefinement logic intoabstract_eval_partition_loadand removing the redirect viaabstract_eval_globalref_partition.Also adds test cases with
assume_bindings_static=true.