Skip to content

Use faster PRNG in the allocations profiler #57761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
+2 −1
Merged

Use faster PRNG in the allocations profiler #57761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/gc-alloc-profiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ void _maybe_record_alloc_to_profile(jl_value_t *val, size_t size, jl_datatype_t

auto& profile = global_profile.per_thread_profiles[thread_id];

auto sample_val = double(rand()) / double(RAND_MAX);
jl_ptls_t ptls = jl_current_task->ptls;
auto sample_val = double(cong(UINT64_MAX, &ptls->rngseed)) / double(UINT64_MAX);
auto should_record = sample_val <= global_profile.sample_rate;
if (!should_record) {
return;
Expand Down