minor speedup in runtests all #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @jiahao , @andreasnoackjensen |
|
Yes, this was essentially what I had in mind in JuliaLang/LinearAlgebra.jl#74. |
|
If there are no objections, I'll merge this in a day or two. |
|
This is great. Cutting off 30 seconds is not minor at all. |
amitmurthy
added a commit
that referenced
this pull request
Feb 11, 2014
minor speedup in runtests all
|
Merged this irrespective of any final strategy adopted in JuliaLang/LinearAlgebra.jl#74 since the number of linalg tests are quite large and will anyway benefit from a split. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested split linalg into 2. Moved parallel last.
This decreased
julia runtests.jl allfrom 120 seconds to 90 seconds on my machine.julia runtests.jl linalgis equivalent tojulia runtests.jl linalg1 linalg2Moved the test of
parallellast - but this is currently mostly ineffective since it just ends up waiting for the linalg workers to finish - need a better way to detect and thus not distribute work to already busy workers - will start a discussion on this feature separately.