WIP: Cleanup of Tridiagonal code #5749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this. I realise that you had a broader perspective with this pr that might overlap with mine (#5759) from last night. Just to indicate what's in the pipe line, I also have a function for real symmetric tridiagonalization in the Quaternions package, but right now it only supports storage in the lower triangle. |
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3
to
1a4c02f
Compare
|
@jiahao is this still needed? |
|
no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventual goal of this PR is to implement the missing functionality referenced by #3688, #5429.
Currently, this just strips out the temporary working variables as fields from within Tridiagonal.