Skip to content

ircode: cleanup code crud #56724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2024
Merged

ircode: cleanup code crud #56724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a0de34
ircode: cleanup code crud
vtjnash Nov 30, 2024
42e14d6
ircode: small optimization for nearby ssavalue
vtjnash Dec 2, 2024
1b37a2f
ircode: avoid serializing ssaflags in the common case when they are a…
vtjnash Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Compiler/test/interpreter_exec.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ let m = Meta.@lower 1 + 1
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.ssaflags = fill(UInt8(0x00), nstmts)
src.ssaflags = fill(zero(UInt32), nstmts)
src.debuginfo = Core.DebugInfo(:none)
Compiler.verify_ir(Compiler.inflate_ir(src))
global test29262 = true
Expand Down Expand Up @@ -63,7 +63,7 @@ let m = Meta.@lower 1 + 1
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.ssaflags = fill(UInt8(0x00), nstmts)
src.ssaflags = fill(zero(UInt32), nstmts)
src.debuginfo = Core.DebugInfo(:none)
m.args[1] = copy(src)
Compiler.verify_ir(Compiler.inflate_ir(src))
Expand Down Expand Up @@ -103,7 +103,7 @@ let m = Meta.@lower 1 + 1
]
nstmts = length(src.code)
src.ssavaluetypes = nstmts
src.ssaflags = fill(UInt8(0x00), nstmts)
src.ssaflags = fill(zero(UInt32), nstmts)
src.debuginfo = Core.DebugInfo(:none)
Compiler.verify_ir(Compiler.inflate_ir(src))
global test29262 = true
Expand Down
3 changes: 2 additions & 1 deletion src/clangsa/GCChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,8 @@ bool GCChecker::isGCTrackedType(QualType QT) {
Name.ends_with_insensitive("jl_vararg_t") ||
Name.ends_with_insensitive("jl_opaque_closure_t") ||
Name.ends_with_insensitive("jl_globalref_t") ||
// Probably not technically true for these, but let's allow it
// Probably not technically true for these, but let's allow it as a root
Name.ends_with_insensitive("jl_ircode_state") ||
Name.ends_with_insensitive("typemap_intersection_env") ||
Name.ends_with_insensitive("interpreter_state") ||
Name.ends_with_insensitive("jl_typeenv_t") ||
Expand Down
Loading
Loading