inference: refine setglobal! rt for invalid assignments
#56622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 20, 2024
Comment on lines
3415
to
3416
| elseif !(wnewty <: ty) | ||
| return Pair{Any,Any}(newty, TypeError) |
There was a problem hiding this comment.
use the typeintersect_tfunc here to compute newty most precisely?
There was a problem hiding this comment.
Do you mean tmeet(𝕃, newty, ty)?
There was a problem hiding this comment.
Yes, I guess that is true. Often the types are in the lifted domain, but in this case the partition_restriction is already in the value domain, so the instanceof_tfunc isn't necessary
vtjnash
approved these changes
Nov 20, 2024
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/setglobal!
branch
from
df74a79
to
b8d6237
Compare
aviatesk
force-pushed
the
avi/setglobal!
branch
from
b8d6237
to
eda5672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nanosoldier
runbenchmarks("inference", vs=":master")