Fix and test special loading support for Compiler #56535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/Compilerloading
branch
4 times, most recently
from
e24ecfc to
42fe66f
Compare
The new `Compiler` package has a special stub that bypasses compilig a separate copy if you have `dev`'ed the version that's already compiled into the sysimg. It wasn't quite working properly in the final version of that PR if a compiler so loaded was a dependency of another precompiled package. Fix that and add a test to make sure it doesn't regress.
Keno
force-pushed
the
kf/Compilerloading
branch
from
d47a1fc to
d55f65e
Compare
|
This PR broke building on powerpc |
vtjnash
reviewed
Nov 14, 2024
Comment on lines
+3941
to
+3943
| // Ordinarily set during deserialization, but our compiler stub image, | ||
| // just returns a reference to the sysimage version, so we set it here. | ||
| topmod->build_id.hi = checksum; |
There was a problem hiding this comment.
This adds a new data race, so it feels rather sketchy, though I don't fully understand this comment
I don't think that's right. There's two issues on powerpc, one is the build not starting at all, which has been happening all week. The other is which appears to have start with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
Compilerpackage has a special stub that bypasses compilig a separate copy if you havedev'ed the version that's already compiled into the sysimg. It wasn't quite working properly in the final version of that PR if a compiler so loaded was a dependency of another precompiled package. Fix that and add a test to make sure it doesn't regress.