Skip to content

Artifacts: use a different way of getting the UUID of a module #55218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Artifacts: use a different way of getting the UUID of a module #55218

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1478f9
Artifacts: use a different way of getting the UUID of a module
KristofferC Jul 23, 2024
8d171f4
fix using module root
KristofferC Jul 23, 2024
6366162
Revert "fix using module root"
KristofferC Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stdlib/Artifacts/src/Artifacts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,10 @@ end

function _artifact_str(__module__, artifacts_toml, name, path_tail, artifact_dict, hash, platform, @nospecialize(lazyartifacts))
moduleroot = Base.moduleroot(__module__)
if haskey(Base.module_keys, moduleroot)
pkg = Base.PkgId(moduleroot)
if pkg.uuid !== nothing
# Process overrides for this UUID, if we know what it is
process_overrides(artifact_dict, Base.module_keys[moduleroot].uuid)
process_overrides(artifact_dict, pkg.uuid)
end

# If the artifact exists, we're in the happy path and we can immediately
Expand Down