Add simple IR printer for the verifier. #54973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
reviewed
Jun 28, 2024
Comment on lines
+15
to
+20
| print(Core.stderr, "Block ") | ||
| print(Core.stderr, block_for_inst(ir, i)) | ||
| print(Core.stderr, " ") | ||
| print(Core.stderr, "%") | ||
| print(Core.stderr, i) | ||
| print(Core.stderr, " = ") |
There was a problem hiding this comment.
Suggested change
| print(Core.stderr, "Block ") | |
| print(Core.stderr, block_for_inst(ir, i)) | |
| print(Core.stderr, " ") | |
| print(Core.stderr, "%") | |
| print(Core.stderr, i) | |
| print(Core.stderr, " = ") | |
| print(Core.stderr, "[", block_for_inst(ir, i), "] %", i, " = ") |
Comment on lines
+22
to
+24
| print(Core.stderr, " :: ") | ||
| print(Core.stderr, ir.stmts[i][:type]) | ||
| println(Core.stderr, "") |
There was a problem hiding this comment.
Suggested change
| print(Core.stderr, " :: ") | |
| print(Core.stderr, ir.stmts[i][:type]) | |
| println(Core.stderr, "") | |
| println(Core.stderr, "::", ir.stmts[i][:type]) |
Comment on lines
+12
to
+13
| print(Core.stderr, " sptypes ") | ||
| println(Core.stderr, ir.sptypes) |
There was a problem hiding this comment.
I think we can exclude these sptypes after all (esp. since their array prints poorly)
| print(Core.stderr, "Verification error in IR for function ") | ||
| print(Core.stderr, ir.argtypes[1]) | ||
| print(Core.stderr, " with args ") | ||
| println(Core.stderr, ir.argtypes[2:end]) |
There was a problem hiding this comment.
This should probably either do its own array printing like you do below, or we should go ahead and finally fix how Array is printed in Core
|
Sounds fine, though I sort of think the full way to do this is to write a parser for the precise output that we do now (for using in a functional julia session) which converts that content back into Expr, then use the standard IR printer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for debugging during bootstrapping.
