Revert changing wrap on Memory to view and make wrap non-public.
#54927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
Jun 25, 2024
aviatesk
reviewed
Jun 26, 2024
|
This PR has been backported so changing milestone to 1.12. |
KristofferC
force-pushed
the
kc/view_wrap_mem
branch
from
0902f77
to
4a2e175
Compare
This was referenced Jul 31, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
|
Is there a reason this is non-public instead of public but non-exported? |
|
Yes, it was more conservative and it wasn't clear if the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54768