Remove references to non opaque pointers in codegen and LLVM passes #54853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gbaraldi
force-pushed
the
gb/no-typed-ref
branch
from
ba603a8
to
ab3cd83
Compare
vchuravy
approved these changes
Jun 20, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jul 10, 2024
…passes (JuliaLang#54853)" This reverts commit 5e1bcdf.
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the bump to LLVM18 where some of these APIs are removed. This also removes uses of bitcasts between pointers since those were already noops and just complicated the code.
This also changes a couple of the GEPs in the code to be int8 GEPs in preparation for whatever version of https://discourse.llvm.org/t/rfc-replacing-getelementptr-with-ptradd/68699 that eventually gets made. In any case LLVM already canonicalizes GEPs to i8 GEPs so this doesn't hurt.