WIP: improve some cases of loading extensions in the presence of packages in the sysimage. #54750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
changed the title
…ps as explicitly loaded this is important for packages in the sysimage whose dependencies should also be marked as loaded when they themselves are loaded
KristofferC
force-pushed
the
kc/ext_fail_load_sysimage
branch
from
1c294dd
to
4760a51
Compare
KristofferC
added a commit
that referenced
this pull request
Oct 22, 2024
…ckages are in the sysimage (#52841) (#56234) This reverts commit 08d229f. There are some bugs now where extensions do not load when their package has been put into the sysimage. #52841 was made because it was common to get cycles otherwise but with #55589 that should be much less of a problem. Subsumes #54750.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52841 was intended to make the loading of extensions be less coupled to what packages are in the sysimage but it didn't get all the way there since the
requirecalls are not "recorded" for packages in the sysimage.In the following situation:
will load the ACExt in the normal case, but will not load it if B (and thus C) is in the sysimage.
This PR starts fixing that but it will still fail if the package in the sysimage ends up getting loaded from another precompiled package.