Disallow Bool indices in structured matrix indexing
#54475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
approved these changes
May 15, 2024
jishnub
force-pushed
the
jishnub/getindexint
branch
from
20d19a8 to
35a3812
Compare
|
Any chance this has been used anywhere? |
|
A PkgEval run might help us catch that, so let's see. I doubt it, though. |
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
Currently,
```julia
julia> B = Bidiagonal(1:3, 1:2, :U)
3×3 Bidiagonal{Int64, UnitRange{Int64}}:
1 1 ⋅
⋅ 2 2
⋅ ⋅ 3
julia> B[3, true]
0
julia> Matrix(B)[3, true]
ERROR: ArgumentError: invalid index: true of type Bool
```
This PR changes the behavior to
```julia
julia> B[3, true]
ERROR: ArgumentError: invalid index: true of type Bool
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
This PR changes the behavior to