Use standard binomial for Integer arguments
#54307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `binomial(Int64(10), Int32(5))` meant the generalized binomial coefficient due to the arguments being of different types, which was in contradiction with the documentation. Fixes JuliaLang#54296
oscardssmith
approved these changes
Apr 29, 2024
oscardssmith
added
bugfix
|
Thanks, I just noticed this. Actually, before the introduction of the generalized binomial coefficient in 1.10 (#48124), the lack of promotion meant that different integer types simply gave an error: julia1.9> binomial(Int32(5), 3)
ERROR: MethodError: no method matching binomial(::Int32, ::Int64)so apparently this has always been broken (going back to Julia 1.0 and earlier). |
stevengj
reviewed
Nov 25, 2024
| @@ -1205,6 +1205,7 @@ Base.@assume_effects :terminates_locally function binomial(n::T, k::T) where T<: | |||
| end | |||
| copysign(x, sgn) | |||
| end | |||
| binomial(n::Integer, k::Integer) = binomial(promote(n, k)...) | |||
There was a problem hiding this comment.
Nitpick: I would have moved this general definition up, to attach it to the docstring.
dkarrasch
pushed a commit
that referenced
this pull request
Nov 26, 2024
Slight tweak to #54307: attach the `binomial(n::Integer, k::Integer)` method to the corresponding docstring, rather than the narrower `binomial(n::T, k::T) where {T<:Integer}` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
binomial(Int64(10), Int32(5))meant the generalized binomial coefficient due to the arguments being of different types, which was in contradiction with the documentation.Fixes #54296