-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export Dates.adjust #53027
Don't export Dates.adjust #53027
Conversation
@nanosoldier |
This has never been part of the public API because the public API is defined to include only things in the manual. |
The package evaluation job you requested has completed - possible new issues were detected. |
Nanosoldier revealed two new failures: OpenSSL extends and reexports Dates itself fails because it expects the symbol QuantLib did not come up in PkgEval because it is skipped. (no updates since 2020, 3 monthly downloads according to JuliaHub, 0 dependants) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming we get Dates tests fixed as @LilithHafner mentioned
This PR broke the |
Dates.adjust
has been exported for a while, but has no docstring and is not in the manual in 1.10.I've asked on Slack, GitHub, and Discourse if anybody is using it, and nobody piped up.
Since we're adding docstrings to everything for 1.11, it seems like a good time to remove the
adjust
export.Resolves #52746.