follow up #52309 #52499
Merged
follow up #52309 #52499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Dec 12, 2023
| stmt = GotoIfNot(v, stmt.dest) | ||
| elseif isa(stmt, EnterNode) | ||
| op == 1 || throw(BoundsError()) | ||
| stmt = EnterNode(stmt.catch_dest, v) |
Member
There was a problem hiding this comment.
This should be stmt.scope now, right (like _useref_getindex)?
Member
Author
There was a problem hiding this comment.
It's not merged yet (#52309). But we probably should keep this handling.
Member
There was a problem hiding this comment.
I think #52309 is good to go, so let me just merge that and then this can be rebased and reviewed on top.
Member
Author
There was a problem hiding this comment.
Ok, so I guess no changes are required on this part now. This PR does some minor followups on #52309.
aviatesk
commented
Dec 13, 2023
| istaskstarted(t) && error("Setting scope on a started task directly is disallowed.") | ||
| end | ||
| return @invoke setproperty!(t::Any, field, v) | ||
| return @invoke setproperty!(t::Any, field::Symbol, v::Any) |
Member
Author
There was a problem hiding this comment.
v::Any particularly eliminates unnecessary call to Core.Typeof.
Keno
approved these changes
Dec 13, 2023
Member
|
Can this get a better title/description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.