compiler: add flag manipulation utilities #52269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Nov 22, 2023
aviatesk
force-pushed
the
avi/flag-op
branch
2 times, most recently
from
2ebeef3 to
6a2bb23
Compare
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Right now, we're checking if a flag exists using bare operations like `&` and `==`. This works fine, but I think unifying these interfaces could make our code easier to maintain. So, this commit introduces some new high-level operators and refactored the code to incorporate them: - `has_flag(curr::UInt32, flag::UInt32)` - `add_flag!(inst::Instruction, flag::UInt32)` - `add_flag!(inst::Instruction, flag::UInt32)` - `sub_flag!(inst::Instruction, flag::UInt32)`
aviatesk
force-pushed
the
avi/flag-op
branch
from
6a2bb23 to
ab8c037
Compare
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Dec 9, 2023
Right now, we're checking if a flag exists using bare operations like `&` and `==`. This works fine, but I think unifying these interfaces could make our code easier to maintain. So, this commit introduces some new high-level operators and refactored the code to incorporate them: - `has_flag(curr::UInt32, flag::UInt32)` - `has_flag(inst::Instruction, flag::UInt32)` - `add_flag!(inst::Instruction, flag::UInt32)` - `sub_flag!(inst::Instruction, flag::UInt32)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we're checking if a flag exists using bare operations like
&and==. This works fine, but I think unifying these interfaces could make our code easier to maintain. So, this commit introduces some new high-level operators and refactored the code to incorporate them:has_flag(curr::UInt32, flag::UInt32)has_flag(inst::Instruction, flag::UInt32)add_flag!(inst::Instruction, flag::UInt32)sub_flag!(inst::Instruction, flag::UInt32)@nanosoldier
runbenchmarks("inference", vs=":master")@Keno @vtjnash @topolarity Are you fine with this?