fix --bug-report=rr
#51750
Merged
fix --bug-report=rr
#51750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is currently broken on nightly due to world age errors
vtjnash
approved these changes
Oct 17, 2023
|
Ah, true! |
|
CI failed |
maleadt
reviewed
Oct 18, 2023
| @@ -246,7 +246,7 @@ function exec_options(opts) | |||
| # If we're doing a bug report, don't load anything else. We will | |||
| # spawn a child in which to execute these options. | |||
| let InteractiveUtils = load_InteractiveUtils() | |||
| InteractiveUtils.report_bug(arg) | |||
| invokelatest(InteractiveUtils.report_bug, arg) | |||
There was a problem hiding this comment.
I tried to copy the style that was used in the Distributed case just below. I don't feel like this makes a huge difference in terms of readability in the single-arg case
|
@Keno Any ideas why this would fail on our CI environment? It worked for me locally even without the selinux shenanigans. Can you think of a better way to do a simple rr smokescreen test? |
|
I skipped the test for now so we can at least merge this fix |
simeonschaub
added a commit
that referenced
this pull request
Oct 19, 2023
follow-up PR to #51750 to figure out how to properly test this
simeonschaub
added a commit
that referenced
this pull request
Oct 20, 2023
follow-up PR to #51750 since BugReporting was broken at the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is currently broken on nightly due to world age errors