Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 1.10 GC back to 1.8 GC heuristics #51661

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Oct 10, 2023

The 1.10 GC heuristics introduced in #50144 have been a source of concerning issues such as #50705 and #51601. The PR also doesn't correctly implement the paper on which it's based, as discussed in #51498.

Test whether the 1.8 GC heuristics are a viable option.

@d-netto d-netto added the GC Garbage collector label Oct 10, 2023
@d-netto d-netto marked this pull request as draft October 10, 2023 16:59
@d-netto d-netto force-pushed the dcn-1.8-heuristics branch 2 times, most recently from 74b967d to 450bf5a Compare October 10, 2023 17:24
@d-netto
Copy link
Member Author

d-netto commented Oct 10, 2023

(Marking as "ready for review" to run a CI pass)

@d-netto d-netto marked this pull request as ready for review October 10, 2023 17:24
@d-netto d-netto changed the base branch from master to backports-release-1.10 October 15, 2023 22:41
@d-netto d-netto changed the base branch from backports-release-1.10 to master October 15, 2023 22:42
@d-netto d-netto changed the base branch from master to backports-release-1.10 October 16, 2023 19:11
@d-netto
Copy link
Member Author

d-netto commented Oct 18, 2023

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@d-netto
Copy link
Member Author

d-netto commented Oct 20, 2023

Will merge tomorrow if there are no objections.

@d-netto d-netto merged commit 3b97715 into backports-release-1.10 Oct 20, 2023
7 checks passed
@d-netto d-netto deleted the dcn-1.8-heuristics branch October 20, 2023 20:43
@oscardssmith oscardssmith changed the title Test for reverting back to 1.8 GC heuristics Revert 1.10 GC back to 1.8 GC heuristics Oct 21, 2023
d-netto added a commit that referenced this pull request Oct 24, 2023
Otherwise `--heap-size-hint` will become a no-op.

Likely a merge bug from #51661.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants