Skip to content

Export num_stack_mappings to track the number of in-flight stack mappings and tasks in application #51301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Export num_stack_mappings to track the number of in-flight stack mappings and tasks in application #51301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be1e218
export num_stack_mappings
Aug 11, 2023
85bbe38
formatting
Sep 13, 2023
a49fa95
add JL_DDLEXPORT jl_get_num_stack_mappings prototype
Sep 13, 2023
be2b41f
add void to the parameter list to emphasize that it does not accept a…
Sep 13, 2023
3a88b66
jl_exported_funcs.inc is aparently not needed in addition to JL_DLLEX…
Sep 13, 2023
982e38c
Add a test for jl_get_num_stack_mappings
NHDaly Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/gc-stacks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ static void free_stack(void *stkbuf, size_t bufsz)
}
#endif

JL_DLLEXPORT uint32_t jl_get_num_stack_mappings(void)
{
return jl_atomic_load_relaxed(&num_stack_mappings);
}

const unsigned pool_sizes[] = {
128 * 1024,
Expand Down
1 change: 1 addition & 0 deletions src/gc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ void gc_count_pool(void);
size_t jl_array_nbytes(jl_array_t *a) JL_NOTSAFEPOINT;

JL_DLLEXPORT void jl_enable_gc_logging(int enable);
JL_DLLEXPORT uint32_t jl_get_num_stack_mappings(void);
void _report_gc_finished(uint64_t pause, uint64_t freed, int full, int recollect, int64_t live_bytes) JL_NOTSAFEPOINT;

#ifdef __cplusplus
Expand Down
6 changes: 6 additions & 0 deletions test/threads.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,3 +331,9 @@ end
@testset "rand_ptls underflow" begin
@test Base.Partr.cong(UInt32(0)) == 0
end

@testset "num_stack_mappings metric" begin
@test @ccall(jl_get_num_stack_mappings()::Cint) >= 1
# There must be at least two: one for the root test task and one for the async task:
@test fetch(@async(@ccall(jl_get_num_stack_mappings()::Cint))) >= 2
end