Skip to content

allow code_[llvm|native] to take custom params::CodegenParams #51109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2023
Merged

allow code_[llvm|native] to take custom params::CodegenParams #51109

merged 1 commit into from
Aug 31, 2023

Conversation

@aviatesk
Copy link
Member

Also cleans up the implementations a bit.

@aviatesk
allow code_[llvm|native] to take custom params::CodegenParams
214650b 
Also cleans up the implementations a bit.
@aviatesk aviatesk force-pushed the avi/code-llvm-params branch from 0431577 to 214650b Compare August 30, 2023 13:59
@aviatesk aviatesk merged commit 81b5a9e into master Aug 31, 2023
@aviatesk aviatesk deleted the avi/code-llvm-params branch August 31, 2023 02:19
@vtjnash vtjnash mentioned this pull request Jan 9, 2024
Closed
vtjnash added a commit that referenced this pull request Oct 2, 2025
@vtjnash
[InteractiveUtils] specify code_warntype vararg length
3502383 
Avoids a stack overflow when mistyping arguments, allowing for a better
MethodError.

Issue introduced by #51109
Fixes #57597
@vtjnash vtjnash mentioned this pull request Oct 2, 2025
Merged
vtjnash added a commit that referenced this pull request Oct 6, 2025
@vtjnash
[InteractiveUtils] specify code_warntype vararg length (#59726)
6e697c3 
Avoids a stack overflow when mistyping arguments, allowing for a better
MethodError.

Issue introduced by #51109
Fixes #57597
KristofferC pushed a commit that referenced this pull request Oct 10, 2025
@vtjnash @KristofferC
[InteractiveUtils] specify code_warntype vararg length (#59726)
12ebee9 
Avoids a stack overflow when mistyping arguments, allowing for a better
MethodError.

Issue introduced by #51109
Fixes #57597

(cherry picked from commit 6e697c3)
KristofferC pushed a commit that referenced this pull request Oct 12, 2025
@vtjnash @KristofferC
[InteractiveUtils] specify code_warntype vararg length (#59726)
7dc1d3a 
Avoids a stack overflow when mistyping arguments, allowing for a better
MethodError.

Issue introduced by #51109
Fixes #57597

(cherry picked from commit 6e697c3)
KristofferC pushed a commit that referenced this pull request Oct 14, 2025
@vtjnash @KristofferC
[InteractiveUtils] specify code_warntype vararg length (#59726)
3eb52df 
Avoids a stack overflow when mistyping arguments, allowing for a better
MethodError.

Issue introduced by #51109
Fixes #57597

(cherry picked from commit 6e697c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aviatesk @vtjnash