Merge new reinterpret with essentials.jl reinterpret
#50367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Jun 30, 2023
dkarrasch
reviewed
Jun 30, 2023
oscardssmith
added
the
needs nanosoldier run
vtjnash
removed
the
needs nanosoldier run
KristofferC
pushed a commit
that referenced
this pull request
Jul 24, 2023
(cherry picked from commit b99f251)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted here: #47116 (comment) #47116 (comment)
the new
reinterpretoverrides one in essentials.jl, leading to warnings and invalidations. This PR seeks to merge them.Should be careful - defining this on the REPL slowed everything down, though that may have just been invalidations leading to recompilation.