Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Allow automatically applying Julia's patches to LLVM source #50208

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

giordano
Copy link
Contributor

This is useful when one wants to build Julia with a non-Julia fork of LLVM, but still apply Julia's patches, to be a good citizen. I'm happy to document these new options in the devdocs if #50207 is accepted.

@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries compiler:llvm For issues that relate to LLVM labels Jun 18, 2023
@DilumAluthge
Copy link
Member

DilumAluthge commented Jun 18, 2023

Would it be possible to eventually add the same feature for other dependencies that we have custom forks of, such as libuv?

@giordano
Copy link
Contributor Author

We don't have stable tags for Julia's libuv, which is a major pain point for downstream packagers like spack, so the answer is no. But also, I'm not sure libuv is so commonly forked as llvm is, for which one may want to compile a fork with a new backend enabled not yet available in upstream (which was the main motivation for my PR).

@staticfloat staticfloat merged commit 8d0d012 into JuliaLang:master Jun 21, 2023
@giordano giordano deleted the mg/external-llvm-patches branch June 21, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies compiler:llvm For issues that relate to LLVM external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants