-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public keyword #50105
Add public keyword #50105
Commits on Jun 26, 2023
-
mwe including
export (scoped-true), a, b, c
andnames
module CreatePairs export create_pair export (scoped-true), cp """ create_pair(x) creates the pair `x => x` """ create_pair(x) = _create_pair(x) """ cp(x) creates the pair `x => x` """ cp(x) = _create_pair(x) """ _create_pair(x) creates the pair `x => x` """ _create_pair(x) = x => x end julia> using .CreatePairs julia> names(CreatePairs) 3-element Vector{Symbol}: :CreatePairs :cp :create_pair julia> names(CreatePairs, scoped=false) 2-element Vector{Symbol}: :CreatePairs :create_pair julia> create_pair(1) 1 => 1 julia> cp(1) ERROR: MethodError: no method matching cp(::Int64) Closest candidates are: cp(::AbstractString, ::AbstractString; force, follow_symlinks) @ Base file.jl:376 Stacktrace: [1] top-level scope @ REPL[7]:1 julia> CreatePairs.cp(1) 1 => 1 julia> _create_pair(1) ERROR: UndefVarError: `_create_pair` not defined Stacktrace: [1] top-level scope @ REPL[9]:1 julia> CreatePairs._create_pair(1) 1 => 1 help?> create_pair search: create_pair create_pair(x) creates the pair x => x help?> CreatePairs.cp cp(x) creates the pair x => x help?> CreatePairs._create_pair _create_pair(x) creates the pair x => x
Lilith Hafner authored and Lilith Hafner committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 5b3d8c1 - Browse repository at this point
Copy the full SHA 5b3d8c1View commit details -
add
Base.isinternal
and use it to flag internal methods in their do……cstrings module CreatePairs export create_pair export (scoped-true), cp """ create_pair(x) creates the pair `x => x` """ create_pair(x) = _create_pair(x) """ cp(x) creates the pair `x => x` """ cp(x) = _create_pair(x) """ _create_pair(x) creates the pair `x => x` """ _create_pair(x) = x => x end julia> using .CreatePairs julia> names(CreatePairs) 3-element Vector{Symbol}: :CreatePairs :cp :create_pair julia> names(CreatePairs, scoped=false) 2-element Vector{Symbol}: :CreatePairs :create_pair julia> create_pair(1) 1 => 1 julia> cp(1) ERROR: MethodError: no method matching cp(::Int64) Closest candidates are: cp(::AbstractString, ::AbstractString; force, follow_symlinks) @ Base file.jl:376 Stacktrace: [1] top-level scope @ REPL[6]:1 julia> CreatePairs.cp(1) 1 => 1 julia> _create_pair(1) ERROR: UndefVarError: `_create_pair` not defined Stacktrace: [1] top-level scope @ REPL[8]:1 julia> CreatePairs._create_pair(1) 1 => 1 help?> create_pair search: create_pair create_pair(x) creates the pair x => x help?> CreatePairs.cp cp(x) creates the pair x => x help?> CreatePairs._create_pair INTERNAL ──────────────────────────────────────────────────────────────────── _create_pair(x) creates the pair x => x
Lilith Hafner authored and Lilith Hafner committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 665855e - Browse repository at this point
Copy the full SHA 665855eView commit details -
Lilith Hafner authored and Lilith Hafner committed
Jun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 52f519e - Browse repository at this point
Copy the full SHA 52f519eView commit details -
add more verbose clarificaiton of what is and is not public API (TODO…
…: trim for concision and clarity)
Lilith Hafner authored and Lilith Hafner committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 03f9e02 - Browse repository at this point
Copy the full SHA 03f9e02View commit details -
add prelimianry list of scoped-exported symbols for review
Lilith Hafner authored and Lilith Hafner committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 7eb64a2 - Browse repository at this point
Copy the full SHA 7eb64a2View commit details -
more docs (implement option 1 of #50105 (comment))
Lilith Hafner authored and Lilith Hafner committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for c7192ea - Browse repository at this point
Copy the full SHA c7192eaView commit details -
Lilith Hafner authored and Lilith Hafner committed
Jun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for ec3b2f3 - Browse repository at this point
Copy the full SHA ec3b2f3View commit details
Commits on Jun 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 804f5ef - Browse repository at this point
Copy the full SHA 804f5efView commit details
Commits on Jul 8, 2023
-
Merge branch 'master' into scoped-export
Lilith Hafner authored and Lilith Hafner committedJul 8, 2023 Configuration menu - View commit details
-
Copy full SHA for 7d404f0 - Browse repository at this point
Copy the full SHA 7d404f0View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 8, 2023 Configuration menu - View commit details
-
Copy full SHA for 4dc10c4 - Browse repository at this point
Copy the full SHA 4dc10c4View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 8, 2023 Configuration menu - View commit details
-
Copy full SHA for 5fd1f64 - Browse repository at this point
Copy the full SHA 5fd1f64View commit details -
more changes for scoped export -> public
Lilith Hafner authored and Lilith Hafner committedJul 8, 2023 Configuration menu - View commit details
-
Copy full SHA for b85ae46 - Browse repository at this point
Copy the full SHA b85ae46View commit details
Commits on Jul 10, 2023
-
try to make public list functional
Lilith Hafner authored and Lilith Hafner committedJul 10, 2023 Configuration menu - View commit details
-
Copy full SHA for acc928a - Browse repository at this point
Copy the full SHA acc928aView commit details
Commits on Jul 18, 2023
-
Lilith Hafner authored and Lilith Hafner committed
Jul 18, 2023 Configuration menu - View commit details
-
Copy full SHA for a5162c2 - Browse repository at this point
Copy the full SHA a5162c2View commit details
Commits on Jul 19, 2023
-
Lilith Hafner authored and Lilith Hafner committed
Jul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for aacc187 - Browse repository at this point
Copy the full SHA aacc187View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 145ad7f - Browse repository at this point
Copy the full SHA 145ad7fView commit details -
clarify internal symbol warning and add test for it
Lilith Hafner authored and Lilith Hafner committedJul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for aea3d22 - Browse repository at this point
Copy the full SHA aea3d22View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for f7d57ba - Browse repository at this point
Copy the full SHA f7d57baView commit details -
don't autocomplete internals (ideally we _would_ autocomplete interna…
…ls for `dev`ed packages and Base if built from source)
Lilith Hafner authored and Lilith Hafner committedJul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 34844bb - Browse repository at this point
Copy the full SHA 34844bbView commit details -
Merge branch 'master' into scoped-export
Lilith Hafner authored and Lilith Hafner committedJul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 8241760 - Browse repository at this point
Copy the full SHA 8241760View commit details -
update FAQ (this change introduces comedy and therefore may be contro…
…versial)
Lilith Hafner authored and Lilith Hafner committedJul 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 920244a - Browse repository at this point
Copy the full SHA 920244aView commit details
Commits on Jul 21, 2023
-
Rename isinternal to ispublic and make all resolved symbols in Main p…
…ublic because it is not idiomatic to mark symbols in Main as public. Helps with repl completions and docstrings. needs tests.
Lilith Hafner authored and Lilith Hafner committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 9e61f96 - Browse repository at this point
Copy the full SHA 9e61f96View commit details -
fix typo in test/reflection.jl
Lilith Hafner authored and Lilith Hafner committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for f75cb68 - Browse repository at this point
Copy the full SHA f75cb68View commit details
Commits on Jul 28, 2023
-
change module docstring warning
Lilith Hafner authored and Lilith Hafner committedJul 28, 2023 Configuration menu - View commit details
-
Copy full SHA for db7ba05 - Browse repository at this point
Copy the full SHA db7ba05View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 28, 2023 Configuration menu - View commit details
-
Copy full SHA for 7dbdd5e - Browse repository at this point
Copy the full SHA 7dbdd5eView commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 28, 2023 Configuration menu - View commit details
-
Copy full SHA for ac11ea4 - Browse repository at this point
Copy the full SHA ac11ea4View commit details
Commits on Jul 29, 2023
-
mostly, this was fixing the test files to either make demo bindings public or expect internal warnings when they are not additionally, fix internal warning for non-markdown content (give up instead of erroring)
Lilith Hafner authored and Lilith Hafner committedJul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for bd0ee87 - Browse repository at this point
Copy the full SHA bd0ee87View commit details -
remove internal warning tests from stdlib/REPL/test/docview.jl becaus…
…e they are adequitely covered in base/test/docs.jl
Lilith Hafner authored and Lilith Hafner committedJul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 1dc9652 - Browse repository at this point
Copy the full SHA 1dc9652View commit details -
restore autocomplete for non-public symbols
Lilith Hafner authored and Lilith Hafner committedJul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 17b8834 - Browse repository at this point
Copy the full SHA 17b8834View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e2ddec - Browse repository at this point
Copy the full SHA 6e2ddecView commit details -
initialize public to false (woops!)
Lilith Hafner authored and Lilith Hafner committedJul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 1000988 - Browse repository at this point
Copy the full SHA 1000988View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for c5955c0 - Browse repository at this point
Copy the full SHA c5955c0View commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 5ed2c7d - Browse repository at this point
Copy the full SHA 5ed2c7dView commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 5da758e - Browse repository at this point
Copy the full SHA 5da758eView commit details -
Lilith Hafner authored and Lilith Hafner committed
Jul 29, 2023 Configuration menu - View commit details
-
Copy full SHA for de8be2b - Browse repository at this point
Copy the full SHA de8be2bView commit details
Commits on Jul 30, 2023
-
bump juliasyntax to merged version
Lilith Hafner authored and Lilith Hafner committedJul 30, 2023 Configuration menu - View commit details
-
Copy full SHA for d75725b - Browse repository at this point
Copy the full SHA d75725bView commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 05352df - Browse repository at this point
Copy the full SHA 05352dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b04f31 - Browse repository at this point
Copy the full SHA 4b04f31View commit details -
Remove symbols from public list
Co-authored-by: Jameson Nash <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 051f824 - Browse repository at this point
Copy the full SHA 051f824View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a56ab4 - Browse repository at this point
Copy the full SHA 8a56ab4View commit details
Commits on Aug 10, 2023
-
remove newlines between bullet points
Lilith Hafner authored and Lilith Hafner committedAug 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 6e2d809 - Browse repository at this point
Copy the full SHA 6e2d809View commit details
Commits on Aug 13, 2023
-
Apply suggestions from code review
Co-authored-by: Claire Foster <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69cf8d4 - Browse repository at this point
Copy the full SHA 69cf8d4View commit details -
Apply suggestions from code review
Co-authored-by: Claire Foster <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9d74beb - Browse repository at this point
Copy the full SHA 9d74bebView commit details -
Merge branch 'master' into scoped-export
Lilith Hafner authored and Lilith Hafner committedAug 13, 2023 Configuration menu - View commit details
-
Copy full SHA for 4b18e1d - Browse repository at this point
Copy the full SHA 4b18e1dView commit details -
Lilith Hafner authored and Lilith Hafner committed
Aug 13, 2023 Configuration menu - View commit details
-
Copy full SHA for 4ba71ab - Browse repository at this point
Copy the full SHA 4ba71abView commit details -
group public symbols a little better
Lilith Hafner authored and Lilith Hafner committedAug 13, 2023 Configuration menu - View commit details
-
Copy full SHA for ce3a798 - Browse repository at this point
Copy the full SHA ce3a798View commit details
Commits on Aug 14, 2023
-
revert names to the most basic implementation (simply swap export=>pu…
…blic) and publicize `isexported` and `ispublic` How to get the old behavior? `filter(isexported, names(args...; kw...)` The set of possible keywods and interacitons is huge and it is better to give folks composable functions than a giant, tangled keyword system that is bound to be eternaly cludgey to maintain backwards compatability. Documents but does not publicize `isdeprecated` and `isbindingresolved`.
Lilith Hafner authored and Lilith Hafner committedAug 14, 2023 Configuration menu - View commit details
-
Copy full SHA for ca8eb44 - Browse repository at this point
Copy the full SHA ca8eb44View commit details -
Lilith Hafner authored and Lilith Hafner committed
Aug 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 6d1e2c7 - Browse repository at this point
Copy the full SHA 6d1e2c7View commit details -
Lilith Hafner authored and Lilith Hafner committed
Aug 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 2678523 - Browse repository at this point
Copy the full SHA 2678523View commit details -
revert unnecessary whitespace change
Lilith Hafner authored and Lilith Hafner committedAug 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 528469b - Browse repository at this point
Copy the full SHA 528469bView commit details -
add tests for ispublic and add more tests for isexported
Lilith Hafner authored and Lilith Hafner committedAug 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 082fb86 - Browse repository at this point
Copy the full SHA 082fb86View commit details -
Lilith Hafner authored and Lilith Hafner committed
Aug 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 3d09dae - Browse repository at this point
Copy the full SHA 3d09daeView commit details
Commits on Sep 4, 2023
-
Do a better job of logging nonpublic access in help mode
Lilith Hafner authored and Lilith Hafner committedSep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 12bab72 - Browse repository at this point
Copy the full SHA 12bab72View commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 0112e2c - Browse repository at this point
Copy the full SHA 0112e2cView commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 66427c6 - Browse repository at this point
Copy the full SHA 66427c6View commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 067d69c - Browse repository at this point
Copy the full SHA 067d69cView commit details -
add tests and fix "public names" header
Lilith Hafner authored and Lilith Hafner committedSep 4, 2023 Configuration menu - View commit details
-
Copy full SHA for b688b60 - Browse repository at this point
Copy the full SHA b688b60View commit details
Commits on Sep 5, 2023
-
update documentation throughout to refer to public and export now-cor…
…rectly
Lilith Hafner authored and Lilith Hafner committedSep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 6ce6fdb - Browse repository at this point
Copy the full SHA 6ce6fdbView commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for e57c63f - Browse repository at this point
Copy the full SHA e57c63fView commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 1a6e3dc - Browse repository at this point
Copy the full SHA 1a6e3dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebcdf24 - Browse repository at this point
Copy the full SHA ebcdf24View commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for d4418fe - Browse repository at this point
Copy the full SHA d4418feView commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for c4924c9 - Browse repository at this point
Copy the full SHA c4924c9View commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 5835699 - Browse repository at this point
Copy the full SHA 5835699View commit details -
try switching to a different JuliaSyntax version
Lilith Hafner authored and Lilith Hafner committedSep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 153b538 - Browse repository at this point
Copy the full SHA 153b538View commit details -
don't accidentally drop the module in testing
Lilith Hafner authored and Lilith Hafner committedSep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 158d59f - Browse repository at this point
Copy the full SHA 158d59fView commit details -
Lilith Hafner authored and Lilith Hafner committed
Sep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 41f3729 - Browse repository at this point
Copy the full SHA 41f3729View commit details
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd5fb90 - Browse repository at this point
Copy the full SHA fd5fb90View commit details
Commits on Sep 7, 2023
-
Docstring fixup for Base.ispublic
Co-authored-by: Gerhard Aigner <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ea7a141 - Browse repository at this point
Copy the full SHA ea7a141View commit details