Skip to content

add a timing zone for call_require #49723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

add a timing zone for call_require #49723

merged 1 commit into from
May 31, 2023

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented May 10, 2023

This adds a zone that "grounds" all the LOAD_Pkgimg Maybe it should be LOAD_Require?

gnome-shell-screenshot-c7enl

topolarity
topolarity approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like LOAD_Require, but either way this is a good zone 👍

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label May 29, 2023
@KristofferC KristofferC merged commit d3d09c1 into master May 31, 2023
@KristofferC KristofferC deleted the kc/require_zone branch May 31, 2023 14:04
@topolarity topolarity removed the merge me PR is reviewed. Merge when all tests are passing label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@topolarity topolarity topolarity approved these changes

Assignees

No one assigned

Labels

profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KristofferC @topolarity @pchintalapudi