prevent REPL from erroring in numbered mode in some situations #49713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
REPL
vtjnash
reviewed
May 10, 2023
vtjnash
reviewed
May 10, 2023
|
Sure, I can. How do I test, BTW? Is there a built version for this? Or I have to fix Julia source files in my installation? |
|
I tried modifying the stdlib files. Unfortunately, it still happens: ChatGPT> Can you give me a quick example of exponentiating a matrix in Julia?
ERROR: type MD has no field args
Stacktrace:
[1] getproperty
@ ./Base.jl:37 [inlined]
[2] get_usings!(usings::Vector{Any}, ex::Markdown.MD)
@ REPL.Numbered ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:1425
[3] out_transform(x::Any, n::Base.RefValue{Int64})
@ REPL.Numbered ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:1415
[4] (::REPL.Numbered.var"#5#6"{Base.RefValue{Int64}})(ast::Any)
@ REPL.Numbered ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:1478
[5] #invokelatest#2
@ ./essentials.jl:816 [inlined]
[6] invokelatest
@ ./essentials.jl:813 [inlined]
[7] eval_user_input(ast::Any, backend::REPL.REPLBackend, mod::Module)
@ REPL ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:151
[8] repl_backend_loop(backend::REPL.REPLBackend, get_module::Function)
@ REPL ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:249
[9] start_repl_backend(backend::REPL.REPLBackend, consumer::Any; get_module::Function)
@ REPL ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:234
[10] run_repl(repl::AbstractREPL, consumer::Any; backend_on_current_task::Bool, backend::Any)
@ REPL ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:379
[11] run_repl(repl::AbstractREPL, consumer::Any)
@ REPL ~/.asdf/installs/julia/1.9.0/share/julia/stdlib/v1.9/REPL/src/REPL.jl:365
[12] (::Base.var"#1017#1019"{Bool, Bool, Bool})(REPL::Module)
@ Base ./client.jl:421
[13] #invokelatest#2
@ ./essentials.jl:816 [inlined]
[14] invokelatest
@ ./essentials.jl:813 [inlined]
[15] run_main_repl(interactive::Bool, quiet::Bool, banner::Bool, history_file::Bool, color_set::Bool)
@ Base ./client.jl:405
[16] exec_options(opts::Base.JLOptions)
@ Base ./client.jl:322
[17] _start()
@ Base ./client.jl:522 |
|
I need to comment these lines in my if !isdefined(repl, :interface)
repl.interface = REPL.setup_interface(repl)
end
REPL.numbered_prompt!(repl) |
51 tasks
35 tasks
KristofferC
added a commit
that referenced
this pull request
Aug 18, 2023
Backported PRs: - [x] #47782 <!-- Generalize Bool parse method to AbstractString --> - [x] #48634 <!-- Remove unused "deps" mechanism in internal sorting keywords [NFC] --> - [x] #49931 <!-- Lock finalizers' lists at exit --> - [x] #50064 <!-- Fix numbered prompt with input only with comment --> - [x] #50474 <!-- docs: Fix a `!!! note` which was miscapitalized --> - [x] #50516 <!-- Fix visibility of assert on GCC12/13 --> - [x] #50635 <!-- `versioninfo()`: include build info and unofficial warning --> - [x] #49915 <!-- Revert "Remove number / vector (#44358)" --> - [x] #50781 <!-- fix `bit_map!` with aliasing --> - [x] #50845 <!-- fix #50438, use default pool for at-threads --> - [x] #49031 <!-- Update inference.md --> - [x] #50289 <!-- Initialize prev_nold and nold in gc_reset_page --> - [x] #50559 <!-- Expand kwcall lowering positional default check to vararg --> - [x] #49582 <!-- Update HISTORY.md for `DelimitedFiles` --> - [x] #50341 <!-- invokelatest docs should say not exported before 1.9 --> - [x] #50525 <!-- only check that values are finite in `generic_lufact` when `check=true` --> - [x] #50444 <!-- Optimize getfield lowering to avoid boxing in some cases --> - [x] #50523 <!-- Avoid generic call in most cases for getproperty --> - [x] #50860 <!-- Add `Base.get_extension` to docs/API --> - [x] #50164 <!-- codegen: handle dead code with unsafe_store of FCA pointers --> - [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` --> - [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception handling. --> Need manual backport: - [ ] #48542 <!-- Add docs on task-specific buffering using multithreading --> - [ ] #50591 <!-- build: fix various makefile bugs --> Non-merged PRs with backport label: - [ ] #50842 <!-- Avoid race conditions with recursive rm --> - [ ] #50823 <!-- Make ranges more robust with unsigned indexes. --> - [ ] #50663 <!-- Fix Expr(:loopinfo) codegen --> - [ ] #49716 <!-- Update varinfo() docstring signature --> - [ ] #49713 <!-- prevent REPL from erroring in numbered mode in some situations --> - [ ] #49573 <!-- Implement jl_cpu_pause on PPC64 --> - [ ] #48726 <!-- fix macro expansion of property destructuring --> - [ ] #48642 <!-- Use gc alloc instead of alloc typed in lowering --> - [ ] #48183 <!-- Don't use pkgimage for package if any includes fall in tracked path for coverage or alloc tracking --> - [ ] #48050 <!-- improve `--heap-size-hint` arg handling --> - [ ] #47615 <!-- Allow threadsafe access to buffer of type inference profiling trees -->
31 tasks
|
Bug was already fixed by #50064, but these are still nice improvements |
vtjnash
added
merge me
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
KristofferC
force-pushed
the
kc/arg_usings
branch
from
0597270 to
aa4ead7
Compare
KristofferC
commented
Oct 2, 2025
| # get all `using` and `import` statements which are at the top level | ||
| for (i, arg) in enumerate(ex.args) | ||
| for i in 1:length(ex.args) | ||
| arg = ex.args[i] |
There was a problem hiding this comment.
The
push!(usings, popat!(ex.args, i))below is kind of sneaky (mutating what we iterate over).
There was a problem hiding this comment.
Wouldn't that mean we used to skip over the next entry after the first using?
There was a problem hiding this comment.
Do we just revert #49098? It seems like this is just entirely too broken
|
Replaced by #59730 |
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #49510.
@singularitti, could you try this?