also load extensions during precompilation #49253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranocha
reviewed
Apr 4, 2023
Co-authored-by: Hendrik Ranocha <[email protected]>
vtjnash
reviewed
Apr 4, 2023
There was a problem hiding this comment.
This would violate the concept of checking that we are not concurrently defining another package. Maybe we should drop this condition entirely again and simply go back to saying cycles result in undefined behavior? Despite earlier claims from some folks, apparently nobody is actually doing that, and Pkg will currently warn you if you tried to.
|
Reverting my last PR regarding this is OK by me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49250