ensure C++ does not free the DebugRegistry while we are using it #49139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++ destructor design tend to cause lifetime problems at exit, so we use `new` to implicitly leak the object.
vtjnash
added
regression
pchintalapudi
approved these changes
Mar 24, 2023
pchintalapudi
added
the
merge me
pchintalapudi
removed
the
merge me
Member
|
Is this applicable to 1.9? |
Member
No. In 1.9 this is owned by |
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ destructor design tend to cause lifetime problems at exit, so we use
newto implicitly leak the object. Seen to possibly cause problems with printing a backtrace after the worker was killed in https://buildkite.com/julialang/julia-master/builds/22082#018701b4-6c16-4559-afdd-e33ece5a6a00. Addresses a regressions caused by 428d242, noted by @pchintalapudi.