Set various array and Random effects #49039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My primary motivation here was to get the Xoshiro constructor to be removed if the RNG is unused (I have a struct that always has an RNG in it, which may or may not be used). I first tried to do that in a more fine-grained way, but #47595 currently makes that infeasible. Nevertheless, I figured it was worth leaving those improvements in so we can switch over once #47595 is resolved. In the meantime, annotate the top-level Xoshiro constructor as `:removable`.
aviatesk
reviewed
Mar 20, 2023
Comment on lines
427
to
431
| function fill!(a::Union{Array{UInt8}, Array{Int8}}, x::Integer) | ||
| @assume_effects :consistent :nothrow :terminates_globally | ||
| ccall(:memset, Ptr{Cvoid}, (Ptr{Cvoid}, Cint, Csize_t), a, convert(eltype(a), x), length(a)) | ||
| return a | ||
| end |
There was a problem hiding this comment.
Suggested change
| function fill!(a::Union{Array{UInt8}, Array{Int8}}, x::Integer) | |
| @assume_effects :consistent :nothrow :terminates_globally | |
| ccall(:memset, Ptr{Cvoid}, (Ptr{Cvoid}, Cint, Csize_t), a, convert(eltype(a), x), length(a)) | |
| return a | |
| end | |
| # native-integer specific method with the guaranteed `:nothrow` annotation | |
| function fill!(a::Union{Array{UInt8}, Array{Int8}}, x::BitInteger) | |
| @assume_effects :consistent :nothrow :terminates_globall | |
| ccall(:memset, Ptr{Cvoid}, (Ptr{Cvoid}, Cint, Csize_t), a, convert(eltype(a), x), length(a)) | |
| return a | |
| end | |
| # general method without the `:nothrow` annotation | |
| function fill!(a::Union{Array{UInt8}, Array{Int8}}, x::Integer) | |
| @assume_effects :consistent :terminates_globall | |
| ccall(:memset, Ptr{Cvoid}, (Ptr{Cvoid}, Cint, Csize_t), a, convert(eltype(a), x), length(a)) | |
| return a | |
| end |
There was a problem hiding this comment.
Probably better to pull out the memset and set effects on it
Comment on lines
-1012
to
+1042
| _growbeg!(a::Vector, delta::Integer) = | ||
| function _growbeg!(a::Vector, delta::Integer) | ||
| @assume_effects :terminates_globally | ||
| ccall(:jl_array_grow_beg, Cvoid, (Any, UInt), a, delta) | ||
| _growend!(a::Vector, delta::Integer) = | ||
| end | ||
| function _growend!(a::Vector, delta::Integer) | ||
| @assume_effects :terminates_globally | ||
| ccall(:jl_array_grow_end, Cvoid, (Any, UInt), a, delta) | ||
| _growat!(a::Vector, i::Integer, delta::Integer) = | ||
| end | ||
| function _growat!(a::Vector, i::Integer, delta::Integer) | ||
| @assume_effects :terminates_globally | ||
| ccall(:jl_array_grow_at, Cvoid, (Any, Int, UInt), a, i - 1, delta) | ||
| end | ||
|
|
||
| # efficiently delete part of an array | ||
|
|
||
| _deletebeg!(a::Vector, delta::Integer) = | ||
| function _deletebeg!(a::Vector, delta::Integer) | ||
| @assume_effects :terminates_globally | ||
| ccall(:jl_array_del_beg, Cvoid, (Any, UInt), a, delta) | ||
| _deleteend!(a::Vector, delta::Integer) = | ||
| end | ||
| function _deleteend!(a::Vector, delta::Integer) | ||
| @assume_effects :terminates_globally | ||
| ccall(:jl_array_del_end, Cvoid, (Any, UInt), a, delta) | ||
| _deleteat!(a::Vector, i::Integer, delta::Integer) = | ||
| end | ||
| function _deleteat!(a::Vector, i::Integer, delta::Integer) | ||
| @assume_effects :terminates_globally | ||
| ccall(:jl_array_del_at, Cvoid, (Any, Int, UInt), a, i - 1, delta) | ||
| end |
There was a problem hiding this comment.
We may want to first merge #47154 in and remove these annotations?
There was a problem hiding this comment.
How does that change alleviate the need for these annotations?
There was a problem hiding this comment.
Ah, sorry, I see you edited the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My primary motivation here was to get the Xoshiro constructor to be removed if the RNG is unused (I have a struct that always has an RNG in it, which may or may not be used). I first tried to do that in a more fine-grained way, but #47595 currently makes that infeasible. Nevertheless, I figured it was worth leaving those improvements in so we can switch over once #47595 is resolved. In the meantime, annotate the top-level Xoshiro constructor as
:removable.