add replace(io, str, patterns...) #48625
Conversation
stevengj
force-pushed
the
replaceio
branch
2 times, most recently
from
84874c9
to
246f2d4
Compare
|
Could someone clarify the naming convention -- why isn't this |
|
@jariji, because we don't use |
|
Would be great to have efficient string functions like this in Julia! But potential consistency and readability is somewhat concerning. My first guess from reading the signature in this PR title was that it performs replacements on the content of |
|
I guess we could call it (Another advantage of Or, since this is not copying from one stream to another, maybe The tradeoff here is that it pollutes the namespace to have a bunch of |
|
Marking as triage since it would be good to get a decision here on both the functionality and the naming. |
|
Triage thinks the name( |
|
The convention being that objects involving |
|
Rebased. Merge? |
|
CI failures seem unrelated? The build seems pretty broken at the moment. 😢 |
|
Yes, only 32-bit windows failed, as it currently does most of the time. |
|
I restarted the build job a few hours after JuliaCI/julia-buildkite#308 was merged, I thought that would have made that work. Edit: I was wrong, simply restarting the job doesn't pick up the new CI configuration. |
|
All green now 🙂 |
|
Unfortunately, looks like this didn't get merged in time for the 1.10 feature freeze. Oh well, it can wait until 1.11 — rebased. |
IanButterworth
added
backport 1.10
|
Seems fair to backport given |
(cherry picked from commit ce1b420)
Backported PRs: - [x] #48625 <!-- add replace(io, str, patterns...) --> - [x] #48387 <!-- Improve documentation of sort-related functions --> - [x] #48363 <!-- Revise sort.md and docstrings in sort.jl --> - [x] #48977 <!-- Update SparseArrays.jl stdlib for SuiteSparse 7 --> - [x] #50719 <!-- fix `CyclePadding(::DataType)` --> - [x] #50694 <!-- inference: permit recursive type traits --> - [x] #50860 <!-- Add `Base.get_extension` to docs/API --> - [x] #50594 <!-- Disallow non-index Integer types in isassigned --> - [x] #50802 <!-- Makes IntrusiveLinkedListSynchronized mutable to avoid allocation on poptask --> - [x] #50858 <!-- Add a `threadpool` parameter to `Channel` constructor --> - [x] #50874 <!-- Restrict COFF to a single thread when symbol count is high --> - [x] #50822 <!-- Add default method for setmodifiers! --> - [x] #50730 <!-- Fix integer overflow in `isapprox` --> - [x] #50850 <!-- Remove weird Rational dispatch and add pi functions to list --> - [x] #50809 <!-- Limit type-printing in MethodError --> - [x] #50915 <!-- Add note the `Task` about sticky bit --> - [x] #50929 <!-- when widening tuple types in tmerge, only widen the complex parts --> - [x] #50928 <!-- Bump JuliaSyntax to 0.4.6 --> - [x] #50959 <!-- Update libssh2 patches --> - [x] #50823 <!-- Make ranges more robust with unsigned indexes. --> - [x] #48542 <!-- Add docs on task-specific buffering using multithreading --> - [x] #50912 <!-- Separate foreign threads into a :foreign threadpool --> - [x] #51010 <!-- Add ORIGIN to SuiteSparse rpath on Linux/FreeBSD --> - [x] #50753 <!-- cat: remove unused promote_eltype methods that confuse inference --> - [x] #51027 <!-- Implement realloc accounting correctly --> - [x] #51019 <!-- fix a case of potentially use of undefined variable when handling error in distributed message processing --> - [x] #51039 <!-- Revert "Optimize findall(f, ::AbstractArray{Bool}) (#42202)" --> - [x] #51036 <!-- add missing invoke edge for nospecialize targets --> - [x] #51042 <!-- inference: fix return_type_tfunc modeling of concrete functions --> - [x] #51114 <!-- Workaround upstream FreeBSD issue #272992 --> - [x] #50892 <!-- Add `JL_DLLIMPORT` to `small_typeof` declaration --> - [x] #51154 <!-- broadcast: use recursion rather than ntuple to map over a tuple --> - [x] #51153 <!-- fix debug typo in "add missing invoke edge for nospecialize targets (#51036)" --> - [x] #51222 <!-- Check again if the tty is open inside the IO lock --> - [x] #51236 <!-- Add lock around uv_unref during init --> - [x] #51243 <!-- GMP: Gracefully handle more overflows. --> - [x] #51254 <!-- Ryu: make sure adding zeros does not overwrite trailing dot --> - [x] #51175 <!-- shorten stale_age for cachefile lock --> - [x] #51300 <!-- fix method definition error for bad vararg --> - [x] #51307 <!-- fix force-throw ctrl-C on Windows --> - [x] #51303 <!-- ensure revising structs is safe --> - [x] #51393 - [x] #51403 Need manual backport: - [x] #51009 <!-- fix #50562, regression in `in` of tuple of Symbols --> - [x] #51053 <!-- Bump Statistics stdlib --> - [x] #51013 <!-- fix #50709, type bound error due to free typevar in sparam env --> - [x] #51305 <!-- reduce test time for rounding and floatfuncs --> Contains multiple commits, manual intervention needed: - [ ] #50663 <!-- Fix Expr(:loopinfo) codegen --> - [ ] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are now first class --> - [ ] #51092 <!-- inference: fix bad effects for recursion --> - [x] #51247 <!-- Check if malloc has succeeded before incrementing gc stats --> - [x] #51294 <!-- use LibGit2_jll for LibGit2 library --> Non-merged PRs with backport label: - [ ] #51132 <!-- Handle `AbstractQ` in concatenation --> - [x] #51029 <!-- testdefs: make sure that if a test set changes the active project, they change it back when they're done --> - [ ] #50919 <!-- Code loading: do the "skipping mtime check for stdlib" check regardless of the value of `ispath(f)` --> - [ ] #50824 <!-- Add some aliasing warnings to docstrings for mutating functions --> - [x] #50385 <!-- Precompile pidlocks: add to NEWS and docs --> - [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
KristofferC
removed
the
backport 1.10
This PR adds an optional
io::IOargument toreplace(str, patterns...)so that the output can be written to anIOstream rather than returning aString. This requires almost no new code, only some refactoring, since internallyreplacewas already implemented by writing to anIOBuffer.As @jakobnissen has pointed out, we have a shortage of in-place operations for strings.
replacewas an egregious example because it was virtually impossible to do in-place without copy-pasting large swathes of code fromBase. Now you can simply write to a pre-allocated, re-usableIOBuffer.This PR was also motivated by a discourse discussion about performing regex substitutions on a file. For large files that cannot simply be read into memory, I realized that this is unnecessarily difficult (especially if you want to use
SubstitutionStringsince it requires a completely undocumented internal_replaceAPI, or multiple replacement patterns). With this PR, it should be possible to simply do:to get something very efficient (after corresponding hooks are added to StringViews.jl to prevent
sfrom being copied to aString).