Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AMD's LWP extension #48131

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Deprecate AMD's LWP extension #48131

merged 2 commits into from
Jan 5, 2023

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jan 5, 2023

Should fix #48111

AMD has deprecated that instruction set in Fam15,
and Linux removed support for it as well as part
of a microcode update.

@vchuravy vchuravy added this to the 1.9 milestone Jan 5, 2023
@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Jan 5, 2023
@mkitti
Copy link
Contributor

mkitti commented Jan 5, 2023

From 9cd9ccbd5a3fe35c62d34682b17961fd23dcf97d Mon Sep 17 00:00:00 2001
From: Mark Kittisopikul <[email protected]>
Date: Thu, 5 Jan 2023 04:40:08 -0500
Subject: [PATCH] Remove lwp feature from bdver1 and later

---
 src/processor_x86.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/processor_x86.cpp b/src/processor_x86.cpp
index 6f064ddd47..c61712ada7 100644
--- a/src/processor_x86.cpp
+++ b/src/processor_x86.cpp
@@ -219,7 +219,7 @@ constexpr auto btver2 = btver1 | get_feature_masks(sse41, sse42, avx, aes, pclmu
                                                    movbe, xsave, xsaveopt);
 
 constexpr auto bdver1 = amdfam10 | get_feature_masks(xop, fma4, avx, ssse3, sse41, sse42, aes,
-                                                     prfchw, pclmul, xsave, lwp);
+                                                     prfchw, pclmul, xsave);
 constexpr auto bdver2 = bdver1 | get_feature_masks(f16c, bmi, tbm, fma);
 constexpr auto bdver3 = bdver2 | get_feature_masks(xsaveopt, fsgsbase);
 constexpr auto bdver4 = bdver3 | get_feature_masks(avx2, bmi2, mwaitx, movbe, rdrnd);
-- 
2.34.1

@vchuravy vchuravy added the merge me PR is reviewed. Merge when all tests are passing label Jan 5, 2023
@vchuravy vchuravy merged commit dc2b4d9 into master Jan 5, 2023
@vchuravy vchuravy deleted the vc/deprecate_lwp branch January 5, 2023 18:32
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Jan 5, 2023
@DilumAluthge DilumAluthge added the bugfix This change fixes an existing bug label Jan 5, 2023
KristofferC pushed a commit that referenced this pull request Jan 10, 2023
@KristofferC KristofferC mentioned this pull request Jan 10, 2023
41 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.9.0-beta2: Unable to find compatible target in system image, when loading a package
7 participants