reflection: support additional call syntaxes for @invoke[latest]#47705
Merged
reflection: support additional call syntaxes for @invoke[latest]#47705
@invoke[latest]#47705Conversation
aviatesk
force-pushed
the
avi/at-invokes
branch
from
18b0b41 to
1a7a043
Compare
Keno
reviewed
Nov 27, 2022
| elseif isexpr(ex, :.) # `x.f` | ||
| f = GlobalRef(mod, :getproperty) | ||
| args = flatten(ex.args) | ||
| elseif isexpr(ex, :ref) # `x[i]` |
Member
There was a problem hiding this comment.
We already have code like this to support the code_* macros. Can we avoid duplicating work here?
Member
Author
There was a problem hiding this comment.
Yeah, we probably want to factor out destructure_callex with
Member
Author
There was a problem hiding this comment.
But maybe with a separate PR.
aviatesk
force-pushed
the
avi/at-invokes
branch
from
1a7a043 to
7d1c780
Compare
vtjnash
reviewed
Nov 28, 2022
Member
Author
|
Let me merge this once CI is green, and work on the refactoring that Keno suggested in this comment in a separate PR. |
aviatesk
commented
Nov 28, 2022
Like `@invoke (xs::Xs)[i::I] = v::V` and `@invokelatest x.f = v`. Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
aviatesk
force-pushed
the
avi/at-invokes
branch
from
2f92890 to
3b3d7bc
Compare
DilumAluthge
removed
the
merge me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like
@invoke (xs::Xs)[i::I] = v::Vand@invokelatest x.f = v.