Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance of isapprox(::AbstractArray, ::AbstractArray) when rtol = 0 #47464

Merged
merged 5 commits into from
Nov 14, 2022
Merged

improve performance of isapprox(::AbstractArray, ::AbstractArray) when rtol = 0 #47464

merged 5 commits into from
Nov 14, 2022

Commits on Nov 14, 2022

  1. improve performance of isapprox(::AbstractArray, ::AbstractArray) w… 

    …hen `rtol = 0`
    @thchr @DilumAluthge
    thchr authored and DilumAluthge committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    7d73e4b View commit details
    Browse the repository at this point in the history

  2. type-stability

    @thchr @DilumAluthge
    thchr authored and DilumAluthge committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    fad528c View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Lilith Orion Hafner <[email protected]>
    @thchr @LilithHafner @DilumAluthge
    2 people authored and DilumAluthge committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5ab0ef4 View commit details
    Browse the repository at this point in the history

  4. keep return for consistency

    @thchr @DilumAluthge
    thchr authored and DilumAluthge committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    bef2820 View commit details
    Browse the repository at this point in the history

  5. drop changes to atol default value

    @thchr @DilumAluthge
    thchr authored and DilumAluthge committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    202d1aa View commit details
    Browse the repository at this point in the history