-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Update Documenter 0.27.23 => 1.2.1 #47105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d64539f to
b24944a
Compare
|
This should be good to go, except that #51328 should get merged first. Other than just bringing the various Documenter improvements, one big thing here is that it will fix the source URLs of the standard libraries. |
A couple small fixes and cosmetic improvements to the Unicode table in the docs: * Most importantly, makes sure that the resulting object from the at-eval block is `Markdown.MD`, which which will be necessary for Documenter 1.0 (#47105). It also fixes the `Markdown.Table` structure -- each of the cells should be an array, not just a string, so it adds one more layer of nesting. * Cosmetically, center-aligns the characters, and wraps the latex commands in `<code>`
|
Assuming all goes well on the CI, I think this is now ready to be merged. |
|
Tried this locally and this PR seems to fix JuliaLang/LinearAlgebra.jl#907. |
|
Oops, sorry I never got around to clicking merge once the CI passed. Thanks @N5N3! |
|
It looks like this didn't fix the standard library links.. the CI build tree difference is causing yet more issues 😢 (which I can replicate locally if I unpack a tarball into Although, in this case, it also looks like Documenter is doing something a bit fishy, since it's failing to create the source links, but it's also not printing any warnings. |
A couple small fixes and cosmetic improvements to the Unicode table in the docs: * Most importantly, makes sure that the resulting object from the at-eval block is `Markdown.MD`, which which will be necessary for Documenter 1.0 (#47105). It also fixes the `Markdown.Table` structure -- each of the cells should be an array, not just a string, so it adds one more layer of nesting. * Cosmetically, center-aligns the characters, and wraps the latex commands in `<code>`
Currently mainly to test a few things on CI here, but will update this to an actual PR once 0.28.0 is out. --------- Co-authored-by: Lilith Orion Hafner <[email protected]>
A couple small fixes and cosmetic improvements to the Unicode table in the docs: * Most importantly, makes sure that the resulting object from the at-eval block is `Markdown.MD`, which which will be necessary for Documenter 1.0 (#47105). It also fixes the `Markdown.Table` structure -- each of the cells should be an array, not just a string, so it adds one more layer of nesting. * Cosmetically, center-aligns the characters, and wraps the latex commands in `<code>`
Currently mainly to test a few things on CI here, but will update this to an actual PR once 0.28.0 is out. --------- Co-authored-by: Lilith Orion Hafner <[email protected]>
Currently mainly to test a few things on CI here, but will update this to an actual PR once 0.28.0 is out.