Skip to content

Conversation

@mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Oct 8, 2022

Currently mainly to test a few things on CI here, but will update this to an actual PR once 0.28.0 is out.

@kshyatt kshyatt added the docsystem The documentation building system label Oct 9, 2022
@mortenpi mortenpi changed the title WIP: Use Documenter 0.28 (-dev for now) Use Documenter 1.0.0 Sep 15, 2023
@mortenpi
Copy link
Contributor Author

mortenpi commented Sep 15, 2023

This should be good to go, except that #51328 should get merged first.

Other than just bringing the various Documenter improvements, one big thing here is that it will fix the source URLs of the standard libraries.

@mortenpi mortenpi marked this pull request as ready for review September 15, 2023 12:24
fredrikekre pushed a commit that referenced this pull request Sep 15, 2023
A couple small fixes and cosmetic improvements to the Unicode table in
the docs:

* Most importantly, makes sure that the resulting object from the
at-eval block is `Markdown.MD`, which which will be necessary for
Documenter 1.0 (#47105). It also fixes the `Markdown.Table` structure --
each of the cells should be an array, not just a string, so it adds one
more layer of nesting.
* Cosmetically, center-aligns the characters, and wraps the latex
commands in `<code>`
@mortenpi mortenpi closed this Sep 15, 2023
@mortenpi mortenpi reopened this Sep 15, 2023
@mortenpi
Copy link
Contributor Author

Assuming all goes well on the CI, I think this is now ready to be merged.

@LilithHafner LilithHafner added the merge me PR is reviewed. Merge when all tests are passing label Nov 29, 2023
@LilithHafner LilithHafner changed the title Use Documenter 1.0.0 Update Documenter 0.27.23 => 1.2.0 Nov 29, 2023
@mortenpi mortenpi changed the title Update Documenter 0.27.23 => 1.2.0 Update Documenter 0.27.23 => 1.2.1 Dec 4, 2023
@N5N3 N5N3 merged commit e0d9cb2 into JuliaLang:master Dec 5, 2023
@N5N3
Copy link
Member

N5N3 commented Dec 5, 2023

Tried this locally and this PR seems to fix JuliaLang/LinearAlgebra.jl#907.

@LilithHafner LilithHafner removed the merge me PR is reviewed. Merge when all tests are passing label Dec 5, 2023
@LilithHafner
Copy link
Member

Oops, sorry I never got around to clicking merge once the CI passed. Thanks @N5N3!

@mortenpi mortenpi deleted the mp/documenter-0.28 branch December 5, 2023 22:11
@mortenpi
Copy link
Contributor Author

mortenpi commented Dec 6, 2023

It looks like this didn't fix the standard library links.. the CI build tree difference is causing yet more issues 😢 (which I can replicate locally if I unpack a tarball into usr/).

Although, in this case, it also looks like Documenter is doing something a bit fishy, since it's failing to create the source links, but it's also not printing any warnings.

fingolfin pushed a commit that referenced this pull request Nov 13, 2025
A couple small fixes and cosmetic improvements to the Unicode table in
the docs:

* Most importantly, makes sure that the resulting object from the
at-eval block is `Markdown.MD`, which which will be necessary for
Documenter 1.0 (#47105). It also fixes the `Markdown.Table` structure --
each of the cells should be an array, not just a string, so it adds one
more layer of nesting.
* Cosmetically, center-aligns the characters, and wraps the latex
commands in `<code>`
fingolfin pushed a commit that referenced this pull request Nov 13, 2025
Currently mainly to test a few things on CI here, but will update this
to an actual PR once 0.28.0 is out.

---------

Co-authored-by: Lilith Orion Hafner <[email protected]>
fingolfin pushed a commit that referenced this pull request Nov 13, 2025
A couple small fixes and cosmetic improvements to the Unicode table in
the docs:

* Most importantly, makes sure that the resulting object from the
at-eval block is `Markdown.MD`, which which will be necessary for
Documenter 1.0 (#47105). It also fixes the `Markdown.Table` structure --
each of the cells should be an array, not just a string, so it adds one
more layer of nesting.
* Cosmetically, center-aligns the characters, and wraps the latex
commands in `<code>`
fingolfin pushed a commit that referenced this pull request Nov 13, 2025
Currently mainly to test a few things on CI here, but will update this
to an actual PR once 0.28.0 is out.

---------

Co-authored-by: Lilith Orion Hafner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsystem The documentation building system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants