Skip to content

throw error when rng sampler is fed empty array #47104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2022
Merged

throw error when rng sampler is fed empty array #47104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8077af3
throw error when rng sampler is fed empty array
Moelf Oct 9, 2022
4941a79
more range->collection
Moelf Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stdlib/Random/src/generation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ SamplerRangeFast(r::AbstractUnitRange{T}) where T<:BitInteger =
SamplerRangeFast(r, uint_sup(T))

function SamplerRangeFast(r::AbstractUnitRange{T}, ::Type{U}) where {T,U}
isempty(r) && throw(ArgumentError("range must be non-empty"))
isempty(r) && throw(ArgumentError("collection must be non-empty"))
m = (last(r) - first(r)) % unsigned(T) % U # % unsigned(T) to not propagate sign bit
bw = (sizeof(U) << 3 - leading_zeros(m)) % UInt # bit-width
mask = ((1 % U) << bw) - (1 % U)
Expand Down Expand Up @@ -284,7 +284,7 @@ SamplerRangeInt(r::AbstractUnitRange{T}) where T<:BitInteger =
SamplerRangeInt(r, uint_sup(T))

function SamplerRangeInt(r::AbstractUnitRange{T}, ::Type{U}) where {T,U}
isempty(r) && throw(ArgumentError("range must be non-empty"))
isempty(r) && throw(ArgumentError("collection must be non-empty"))
a = first(r)
m = (last(r) - first(r)) % unsigned(T) % U
k = m + one(U)
Expand Down Expand Up @@ -330,7 +330,7 @@ struct SamplerRangeNDL{U<:Unsigned,T} <: Sampler{T}
end

function SamplerRangeNDL(r::AbstractUnitRange{T}) where {T}
isempty(r) && throw(ArgumentError("range must be non-empty"))
isempty(r) && throw(ArgumentError("collection must be non-empty"))
a = first(r)
U = uint_sup(T)
s = (last(r) - first(r)) % unsigned(T) % U + one(U) # overflow ok
Expand Down Expand Up @@ -369,7 +369,7 @@ end
function SamplerBigInt(::Type{RNG}, r::AbstractUnitRange{BigInt}, N::Repetition=Val(Inf)
) where {RNG<:AbstractRNG}
m = last(r) - first(r)
m.size < 0 && throw(ArgumentError("range must be non-empty"))
m.size < 0 && throw(ArgumentError("collection must be non-empty"))
nlimbs = Int(m.size)
hm = nlimbs == 0 ? Limb(0) : GC.@preserve m unsafe_load(m.d, nlimbs)
highsp = Sampler(RNG, Limb(0):hm, N)
Expand Down