Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure UnionAll is handled by subtype_unionall #46978

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Sep 29, 2022

This is needed to keep the correctness of envout
Close #46970. Example from #46784 has been added.

@vtjnash
Copy link
Member

vtjnash commented Sep 29, 2022

@nanosoldier runbenchmarks(!"scalar"&&!"union", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 29, 2022
@N5N3 N5N3 merged commit 51d1a56 into JuliaLang:master Oct 2, 2022
@N5N3 N5N3 deleted the unionall_fix branch October 2, 2022 10:25
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect env computed for trivial UnionAll over Union
4 participants