Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalidations in binaryplatforms.jl from Static.jl #46547

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Aug 30, 2022

This is based on the following code:

julia> using Pkg; Pkg.activate(temp=true); Pkg.add("Static")

julia> using SnoopCompileCore; invalidations = @snoopr(using Static); using SnoopCompile

julia> trees = invalidation_trees(invalidations)
inserting !(::False) in Static at ~/.julia/packages/Static/sVI3g/src/Static.jl:427 invalidated:
...
                 76: signature Tuple{typeof(!), Any} triggered MethodInstance for Base.BinaryPlatforms.platforms_match(::Base.BinaryPlatforms.AbstractPlatform, ::Base.BinaryPlatforms.Platform) (85 children)
...

I suggest the labels latency and backport-1.8.

@aviatesk
Copy link
Member

A general request: can you change commit message to e.g.

improve type stability of `platforms_match(::AbstractPlatform, ::AbstractPlatform)`

This improvement prevents invalidations in binaryplatforms.jl when loading Static.jl.

since I think it more clarifies the purpose of commits?

@ranocha
Copy link
Member Author

ranocha commented Aug 30, 2022

Sure, I will try to remember this for the future 👍

@timholy timholy merged commit 25a07bf into JuliaLang:master Aug 31, 2022
@ranocha ranocha deleted the patch-4 branch August 31, 2022 12:15
@ranocha
Copy link
Member Author

ranocha commented Aug 31, 2022

Thanks! Could we the label backport-1.8 to get this into Julia v1.8.1?

@giordano giordano added compiler:latency Compiler latency backport 1.8 Change should be backported to release-1.8 labels Aug 31, 2022
ranocha added a commit to ranocha/julia that referenced this pull request Sep 7, 2022
…ractPlatform)` (JuliaLang#46547)

This improvement prevents invalidations in binaryplatforms.jl when loading Static.jl.
ranocha added a commit to ranocha/julia that referenced this pull request Sep 7, 2022
…ractPlatform)` (JuliaLang#46547)

This improvement prevents invalidations in binaryplatforms.jl when loading Static.jl.
KristofferC pushed a commit that referenced this pull request Sep 7, 2022
…ractPlatform)` (#46547)

This improvement prevents invalidations in binaryplatforms.jl when loading Static.jl.

(cherry picked from commit 25a07bf)
@KristofferC KristofferC mentioned this pull request Sep 7, 2022
28 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants