Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize lyap and sylvester to abstract matrices #46545

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Generalize lyap and sylvester to abstract matrices #46545

merged 4 commits into from
Sep 1, 2022

Conversation

dkarrasch
Copy link
Member

Replaces/closes #38177.

@dkarrasch dkarrasch added the domain:linear algebra Linear algebra label Aug 30, 2022
@dkarrasch
Copy link
Member Author

I'll generalize sylvester the same way, will push shortly.

@dkarrasch dkarrasch changed the title Generalize lyap to abstract matrices Generalize lyap and sylvester to abstract matrices Aug 30, 2022
@dkarrasch
Copy link
Member Author

This is safe BTW because schur will create dense mutable copies (since #40831, v1.8) which we then continue to work with, so allowing non-strided matrices is no problem.

@dkarrasch dkarrasch merged commit cb5f401 into master Sep 1, 2022
@dkarrasch dkarrasch deleted the dk/lyap branch September 1, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dkarrasch