Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce SparseArrays in the system image #46278

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Aug 7, 2022

Reverting #44247 in order to avoid the impact on startup time for several packages. The impact is about 2 seconds, but it affects several packages that do not always need SparseArrays, but are forced to have that dependency due to lack of conditional dependencies, which we hope to have in 1.10.

We do not need to reintroduce SuiteSparse separately since it was reintegrated into SparseArrays.jl in order to maintain backwards compatibility.

cc @Wimmerer

@ViralBShah ViralBShah added backport 1.8 Change should be backported to release-1.8 compiler:latency Compiler latency sparse Sparse arrays labels Aug 7, 2022
@IanButterworth
Copy link
Member

I don't think this needs backport. It's in the sysimage in 1.8

@rayegun
Copy link
Member

rayegun commented Aug 7, 2022

I expected this. Is this the plan for all stdlibs that were being removed?

@ViralBShah ViralBShah removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
@ViralBShah
Copy link
Member Author

ViralBShah commented Aug 7, 2022

We still hope to keep DelimitedFiles in 1.9 out of the sysimage, and hopefully also remove it all the way from stdlib. That should give us some experience when it comes to SparseArrays for 1.10. @KristofferC may be able to say more.

@ViralBShah
Copy link
Member Author

I can't quite tell what is causing the failing darwin x64 test. Doesn't feel related to this PR.

@ViralBShah ViralBShah merged commit 237c8d3 into master Aug 10, 2022
@ViralBShah ViralBShah deleted the vs/sparsesysimage branch August 10, 2022 13:41
@ViralBShah
Copy link
Member Author

@SobhanMP Heads up.

ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
IanButterworth added a commit to IanButterworth/julia that referenced this pull request Nov 30, 2022
IanButterworth added a commit to IanButterworth/julia that referenced this pull request Nov 30, 2022
@A-childs-encyclopedia
Copy link

We still hope to keep DelimitedFiles in 1.9 out of the sysimage, and hopefully also remove it all the way from stdlib. That should give us some experience when it comes to SparseArrays for 1.10. @KristofferC may be able to say more.

Why does it need to be removed?

@SobhanMP
Copy link
Contributor

SobhanMP commented Apr 7, 2023

So we can bump the package w/o bumping Julia or needing to backport (or at least make the process easier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants