Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@kwdef: handle const and atomic fields #46276

Merged
merged 4 commits into from
Aug 9, 2022
Merged

@kwdef: handle const and atomic fields #46276

merged 4 commits into from
Aug 9, 2022

Conversation

IanButterworth
Copy link
Member

Fixes #45020
Fixes #45573

aviatesk
aviatesk reviewed Aug 8, 2022
View reviewed changes
base/util.jl Outdated Show resolved Hide resolved
@IanButterworth @aviatesk
Update base/util.jl
a39ba06 
Co-authored-by: Shuhei Kadowaki <[email protected]>
aviatesk
aviatesk approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, LGTM.

@IanButterworth IanButterworth merged commit 70656e2 into JuliaLang:master Aug 9, 2022
@IanButterworth IanButterworth deleted the ib/kwdef_fixes branch August 9, 2022 22:41
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
@IanButterworth
@kwdef: handle const and atomic fields (JuliaLang#46276)
56c9703
@IanButterworth IanButterworth added the backport 1.8 Change should be backported to release-1.8 label Aug 18, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@IanButterworth @pcjentsch
@kwdef: handle const and atomic fields (JuliaLang#46276)
68e1f18
KristofferC pushed a commit that referenced this pull request Aug 26, 2022
@IanButterworth @KristofferC
@kwdef: handle const and atomic fields (#46276)
72b7511 
(cherry picked from commit 70656e2)
@KristofferC KristofferC mentioned this pull request Aug 26, 2022
Merged
35 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

at-kwdef not working with const fields Base.@kwdef structs constructor ignores @atomic fields
3 participants
@IanButterworth @aviatesk @KristofferC