WIP Adds session id to REPL history (#44681)#45076
WIP Adds session id to REPL history (#44681)#45076bdc34 wants to merge 2 commits intoJuliaLang:masterfrom
Conversation
| REPLHistoryProvider(mode_mapping::Dict{Symbol}) = | ||
| REPLHistoryProvider(String[], nothing, 0, 0, -1, IOBuffer(), | ||
| nothing, mode_mapping, UInt8[]) | ||
| nothing, mode_mapping, UInt8[], UUID(rand(UInt128))) |
There was a problem hiding this comment.
Maybe could use uuid4() instead of UUID(rand(UInt128))?
|
I'm not entirely sure about this. I think I'd prefer to have an option to shard the history file by process, which would also help with situations where the |
|
PIDs aren't guaranteed to be unique even within an OS boot, nor across boots.
https://en.wikipedia.org/wiki/Process_identifier Why is uuid not suitable for shared filesystems? |
This adds a session UUID to the repl history.
#44681