Skip to content

Revert "Profile.Allocs: Add task and timestamp"#44158

Merged
DilumAluthge merged 1 commit into
masterfrom
revert-44055-jps/alloc-ns-ct
Feb 13, 2022
Merged

Revert "Profile.Allocs: Add task and timestamp"#44158
DilumAluthge merged 1 commit into
masterfrom
revert-44055-jps/alloc-ns-ct

Conversation

@DilumAluthge

Copy link
Copy Markdown
Member

Reverts #44055

This broke analyzegc.

/cache/build/default-amdci5-2/julialang/julia-master/src/gc-alloc-profiler.cpp:140:9: error: Calling potential safepoint from function annotated JL_NOTSAFEPOINT [julia.GCChecker]

@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2022
@DilumAluthge
DilumAluthge requested review from NHDaly and tkf February 13, 2022 08:09
@DilumAluthge
DilumAluthge merged commit 5cff625 into master Feb 13, 2022
@DilumAluthge
DilumAluthge deleted the revert-44055-jps/alloc-ns-ct branch February 13, 2022 08:27
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2022
@DilumAluthge

Copy link
Copy Markdown
Member Author

@jpsamaroo @tkf @vchuravy @vtjnash @NHDaly Just wanted to make sure that you saw this revert.

antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant