Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix LLVM link to include new zlib dependency #42524

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix LLVM link to include new zlib dependency #42524

merged 1 commit into from
Oct 6, 2021

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added building Build system, or building Julia or its dependencies bugfix This change fixes an existing bug labels Oct 6, 2021
@JeffBezanson JeffBezanson force-pushed the jb/llvmzlib branch 2 times, most recently from b6cc63b to 35d9e7e Compare October 6, 2021 21:24
vchuravy
vchuravy reviewed Oct 6, 2021
View reviewed changes
deps/llvm.mk
@@ -83,7 +83,7 @@ LLVM_CXXFLAGS += $(CXXFLAGS)
LLVM_CPPFLAGS += $(CPPFLAGS)
LLVM_LDFLAGS += $(LDFLAGS)
LLVM_CMAKE += -DLLVM_TARGETS_TO_BUILD:STRING="$(LLVM_TARGETS)" -DCMAKE_BUILD_TYPE="$(LLVM_CMAKE_BUILDTYPE)"
LLVM_CMAKE += -DLLVM_ENABLE_ZLIB=OFF -DLLVM_ENABLE_LIBXML2=OFF -DLLVM_HOST_TRIPLE="$(or $(XC_HOST),$(BUILD_MACHINE))"
LLVM_CMAKE += -DLLVM_ENABLE_ZLIB=ON -DLLVM_ENABLE_LIBXML2=OFF -DLLVM_HOST_TRIPLE="$(or $(XC_HOST),$(BUILD_MACHINE))"
Copy link
Member

@vchuravy vchuravy Oct 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs something like: LLVM_CMAKE += -DZLIB_DIR="$(build_prefix)"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point it looks like we should just fix the default build first, and figure this out after.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our shiny new nightly-testing builds are hitting the lack of something like LLVM_CMAKE += -DZLIB_DIR="$(build_prefix)" that Valentin identifies:

../../../bin/llvm-tblgen: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory
make[4]: *** [include/llvm/IR/CMakeFiles/intrinsics_gen.dir/build.make:155: include/llvm/IR/Attributes.inc] Error 127
make[3]: *** [CMakeFiles/Makefile2:8973: include/llvm/IR/CMakeFiles/intrinsics_gen.dir/all] Error 2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link? I checked locally today and found it not necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regrets, I meant RAI's shiny new nightly-testing builds, so no link. I can share more via other channels or a call though :).

@vtjnash vtjnash merged commit 2f00fe1 into master Oct 6, 2021
@vtjnash vtjnash deleted the jb/llvmzlib branch October 6, 2021 23:07
@vtjnash
Copy link
Member

vtjnash commented Oct 6, 2021

It looks like it got passed the problem areas, though buildkite is very angry right now at other reasons.

Though possibly one seems relevant to you Jeff (musl):

compiler/codegen                   (10) \|         failed at 2021-10-06T22:03:40.655
  | Error During Test at /cache/build/amdci8-1/julialang/julia-master/julia-78c8f0fcc0/share/julia/test/compiler/codegen.jl:645
  | Test threw exception
  | Expression: readchomp(`$pfx/bin/$(Base.julia_exename()) -e 'println("no codegen!")'`) == "no codegen!"
  | IOError: could not spawn `/tmp/jl_nDANnh/bin/julia -e 'println("no codegen!")'`: no such file or directory (ENOENT)

@vchuravy vchuravy mentioned this pull request Oct 7, 2021
Merged
vchuravy pushed a commit that referenced this pull request Oct 7, 2021
@JeffBezanson @vchuravy
fix LLVM link to include new zlib dependency (#42524)
36f42fc 
(cherry picked from commit 2f00fe1)
vchuravy added a commit that referenced this pull request Oct 8, 2021
@vchuravy
fixup! fix LLVM link to include new zlib dependency (#42524)
cc0989b
vchuravy pushed a commit that referenced this pull request Oct 8, 2021
@JeffBezanson @vchuravy
fix LLVM link to include new zlib dependency (#42524)
07e1754 
(cherry picked from commit 2f00fe1)
vchuravy pushed a commit that referenced this pull request Oct 9, 2021
@JeffBezanson @vchuravy
fix LLVM link to include new zlib dependency (#42524)
4b768de 
(cherry picked from commit 2f00fe1)
@rbvermaa rbvermaa mentioned this pull request Oct 13, 2021
Merged
vchuravy pushed a commit that referenced this pull request Oct 13, 2021
@JeffBezanson @vchuravy
fix LLVM link to include new zlib dependency (#42524)
3a383ea 
(cherry picked from commit 2f00fe1)
nalimilan
nalimilan reviewed Oct 23, 2021
View reviewed changes
deps/llvm.mk
@@ -283,7 +283,7 @@ $(eval $(call LLVM_PATCH,llvm7-symver-jlprefix))
endif

# declare that all patches must be applied before running ./configure
$(LLVM_BUILDDIR_withtype)/build-configured: | $(LLVM_PATCH_PREV)
$(LLVM_BUILDDIR_withtype)/build-configured: | $(LLVM_PATCH_PREV) $(build_prefix)/manifest/zlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition broke USE_SYSTEM_ZLIB=1: now the build always tries to download the zlib sources (and fails if network is unavailable).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been #44584 (comment)?

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@JeffBezanson @LilithHafner
fix LLVM link to include new zlib dependency (JuliaLang#42524)
53d52d9
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@JeffBezanson @LilithHafner
fix LLVM link to include new zlib dependency (JuliaLang#42524)
fc4604c
@giordano giordano mentioned this pull request Apr 28, 2022
Closed
@benlorenz benlorenz mentioned this pull request Nov 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 left review comments

@nalimilan nalimilan nalimilan left review comments

@giordano giordano giordano left review comments

@vchuravy vchuravy vchuravy left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JeffBezanson @vtjnash @vchuravy @giordano @nalimilan @Sacha0