Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated checksums for LBT #42334

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Updated checksums for LBT #42334

merged 1 commit into from
Sep 21, 2021

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah
Copy link
Member Author

yikes - why is whitespace stuck?

@DilumAluthge
Copy link
Member

We temporarily had a configuration error in Buildkite. Fixed now. I've restarted the Buildkite job.

@ViralBShah ViralBShah merged commit f60736f into master Sep 21, 2021
@ViralBShah ViralBShah deleted the vs/lbt-checksums branch September 21, 2021 23:30
KristofferC pushed a commit that referenced this pull request Sep 28, 2021
@Sacha0
Copy link
Member

Sacha0 commented Nov 15, 2021

We are seeing build failures on 1.7-RC3 for lack of this patch, e.g. locally on a fresh 1.7-RC3 checkout:

julia7 % make -f contrib/refresh_checksums.mk blastrampoline
/Library/Developer/CommandLineTools/usr/bin/make -s -C "/Users/sacha/pkg/julia7/deps" USE_BINARYBUILDER=0 FC_VERSION=7.0.0 BLASTRAMPOLINE_BB_TRIPLET= LLVM_ASSERTIONS=0 DEPS_GIT=0 checksum-blastrampoline
===============================================================================
  ERROR: sha512 checksum failure on blastrampoline-23de7a09bf354fe6f655c457bab5bf47fdd2486d.tar.gz, should be:
      7b7dbb101cf05ac833a8e5b09f1eec8eb99f0caafbe80075751a5f7e0bfe03a3
      b19d11d3507dadd13f503cfa9fc1a6cd53f3461af7d5afb39ca385a0ee26120b
  But `sha512sum /Users/sacha/pkg/julia7/deps/srccache/blastrampoline-23de7a09bf354fe6f655c457bab5bf47fdd2486d.tar.gz | awk '{ print $1; }'` results in:
      1c2558bab0aeaa76e7094d8a6a9798c95f2cf4efe2960640b70f1fd752f3dfb7
      3813d9de93b539426376571febaab22ac22c2f903ccdf3296c7b067af92fecdc
  This can happen due to bad downloads or network proxies, please check your
  network proxy/firewall settings and delete
  /Users/sacha/pkg/julia7/deps/srccache/blastrampoline-23de7a09bf354fe6f655c457bab5bf47fdd2486d.tar.gz
  to force a redownload when you are ready
===============================================================================
make[1]: *** [checksum-blastrampoline] Error 2
make: [checksum-blastrampoline-src-] Error 2 (ignored)

so I have marked it for backport to 1.7.

KristofferC pushed a commit that referenced this pull request Nov 19, 2021
(cherry picked from commit f60736f)
KristofferC pushed a commit that referenced this pull request Nov 26, 2021
(cherry picked from commit f60736f)
KristofferC pushed a commit that referenced this pull request Nov 26, 2021
(cherry picked from commit f60736f)
@nalimilan
Copy link
Member

Any idea why these checksums changed upstream? It's not ideal to have retroactive changes like that, it means that previous releases won't build if they download blastrampoline (like in Fedora).

@ViralBShah
Copy link
Member Author

ViralBShah commented Dec 1, 2021

I don't remember now. :-(

IIRC, we recently fixed a bug in the checksums script and the buggy version may have caused this. This is the first release with LBT though, so it shouldn't affect older releases, right?

@DilumAluthge
Copy link
Member

We did fix some bugs in the checksums script, but as far as I can tell, none of those changes should have caused different checksum values to be computed.

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants